Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feature request) full black theme as well as dark theme #49

Open
realeatham opened this issue Apr 16, 2024 · 4 comments
Open

(feature request) full black theme as well as dark theme #49

realeatham opened this issue Apr 16, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@realeatham
Copy link

See title

@tfonteyn
Copy link
Owner

Not sure what you mean?

The app offers (in Settings) to use Light/Dark or "follow-the-device day/night". If you as I suspect mean extra Themes to those, then I regret to say, but I currently have no plans. There are other things which will get priority.

@tfonteyn tfonteyn self-assigned this Apr 16, 2024
@tfonteyn tfonteyn added the enhancement New feature or request label Apr 16, 2024
@realeatham
Copy link
Author

Yes, I meant another theme. Can you leave the issue open incase you or someone else wants to add it in the future?

@tfonteyn
Copy link
Owner

sure - but it will require some work, it's not just adding it to a list. Day/Night is something Android supports via an API. Extra Themes work slightly differently.

@tfonteyn tfonteyn removed their assignment Apr 21, 2024
@tfonteyn
Copy link
Owner

tfonteyn commented Jun 9, 2024

@realeatham

Here's your chance - I implemented #46 in such a way that I can now support multiple themes.

My classic "Blue/Grey" scheme is defined in style name="Theme.App", in this source file

I don't know how familiar (if at all) you are with Android development or its color use?
If you want to have a go with the Theme Builder perhaps?

And no worry, I don't expect a ready-solution; but if you can play around with that tool (or any other of your liking) and come up with color definitions for the "primary" and "secondary" colors (see above source code), there are 9 colors + 1 for the background to define. The "surface" colors I can extrapolate from those prim/sec colors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants