Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New website feedback (Q3 2021) #160

Open
jorgelainfiesta opened this issue Sep 30, 2021 · 3 comments
Open

New website feedback (Q3 2021) #160

jorgelainfiesta opened this issue Sep 30, 2021 · 3 comments

Comments

@jorgelainfiesta
Copy link
Contributor

jorgelainfiesta commented Sep 30, 2021

Please add your feedback, bugs, comments, etc. Thanks!

Known issues

  • Animations still have some more fine tuning pending, but I used them because I think the good outweights the bad.
  • I want to stop the animations when the contact form is open, but when I did try to implement the feature, the form process would get blocked or something like that. I need some help, maybe it's about concurrency?
  • Page loading is blocked by animation, I think it's because Gatsby inlines the SVG. We might want to experiment with loading the SVG animation async
  • Pages titles shouldn't have | Frontside at the end, I had removed it; I guess it came back during a rebase and I didn't notice
@cowboyd
Copy link
Member

cowboyd commented Oct 1, 2021

Referencing #153 (comment)

The simple change from "deliveries" -> "delivery" is a good one, but I think it still needs some refinement. Carrying that over to this issue.

@jbolda
Copy link
Contributor

jbolda commented Oct 4, 2021

There are a handful of pages (I think everything with animations) where the animation (or something) expands out of its parent container and adds a side scroll at certain page widths. For example, on the homepage shrink the page width from a full width towards a mobile width and note the side scroll that is added (in an intermediate width, like ~980px).

@jorgelainfiesta
Copy link
Contributor Author

jorgelainfiesta commented Oct 5, 2021

Thanks @jbolda ! can you tell me which browser you're using? I don't know how to reproduce it. It might be related to the bounding boxes of the animations, I did a dirty CSS hack while the designers provided me cleanly cut SVGs.

Update: I got it!! I'll try to resolve it asap, thanks!

Update 2: I've only found the issue on the homepage, it's caused by the SVG graph that is rendered as a react component: it doesn't resize correctly.

Update 3: Issue was fixed in #161

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants