diff --git a/end-to-end-test/local/specs/hide-download-controls.spec.js b/end-to-end-test/local/specs/hide-download-controls.spec.js index e52c8d202be..863cf141dd8 100644 --- a/end-to-end-test/local/specs/hide-download-controls.spec.js +++ b/end-to-end-test/local/specs/hide-download-controls.spec.js @@ -457,6 +457,7 @@ describe('hide download controls feature', function() { 'Clinical Data', 'CN Segments', 'Files & Links', + 'Plots Beta!', 'Study Sponsors', ]; before(() => { diff --git a/end-to-end-test/remote/screenshots/reference/can_filter_a_study_by_patient_treatments_element_chrome_1600x1000.png b/end-to-end-test/remote/screenshots/reference/can_filter_a_study_by_patient_treatments_element_chrome_1600x1000.png index ea5f53ad2e2..34bc92a4ab0 100644 Binary files a/end-to-end-test/remote/screenshots/reference/can_filter_a_study_by_patient_treatments_element_chrome_1600x1000.png and b/end-to-end-test/remote/screenshots/reference/can_filter_a_study_by_patient_treatments_element_chrome_1600x1000.png differ diff --git a/end-to-end-test/remote/screenshots/reference/can_filter_a_study_by_sample_treatments_element_chrome_1600x1000.png b/end-to-end-test/remote/screenshots/reference/can_filter_a_study_by_sample_treatments_element_chrome_1600x1000.png index 3ee3fc1fb73..aa0f2266b67 100644 Binary files a/end-to-end-test/remote/screenshots/reference/can_filter_a_study_by_sample_treatments_element_chrome_1600x1000.png and b/end-to-end-test/remote/screenshots/reference/can_filter_a_study_by_sample_treatments_element_chrome_1600x1000.png differ diff --git a/end-to-end-test/remote/screenshots/reference/check_for_survival_plots_element_chrome_1600x1000.png b/end-to-end-test/remote/screenshots/reference/check_for_survival_plots_element_chrome_1600x1000.png index 3091084a6e2..3af4d1257ba 100644 Binary files a/end-to-end-test/remote/screenshots/reference/check_for_survival_plots_element_chrome_1600x1000.png and b/end-to-end-test/remote/screenshots/reference/check_for_survival_plots_element_chrome_1600x1000.png differ diff --git a/end-to-end-test/remote/screenshots/reference/excluding_unprofiled_samples_plots_tab_element_chrome_1600x1000.png b/end-to-end-test/remote/screenshots/reference/excluding_unprofiled_samples_plots_tab_element_chrome_1600x1000.png index 6ed07b3d015..fc4e35d177b 100644 Binary files a/end-to-end-test/remote/screenshots/reference/excluding_unprofiled_samples_plots_tab_element_chrome_1600x1000.png and b/end-to-end-test/remote/screenshots/reference/excluding_unprofiled_samples_plots_tab_element_chrome_1600x1000.png differ diff --git a/end-to-end-test/remote/screenshots/reference/filter_study_from_url_element_chrome_1600x1000.png b/end-to-end-test/remote/screenshots/reference/filter_study_from_url_element_chrome_1600x1000.png index eef23e5dc8e..64369ad037d 100644 Binary files a/end-to-end-test/remote/screenshots/reference/filter_study_from_url_element_chrome_1600x1000.png and b/end-to-end-test/remote/screenshots/reference/filter_study_from_url_element_chrome_1600x1000.png differ diff --git a/end-to-end-test/remote/screenshots/reference/fusion_filter_filter_study_from_url_element_chrome_1600x1000.png b/end-to-end-test/remote/screenshots/reference/fusion_filter_filter_study_from_url_element_chrome_1600x1000.png index 72df0b82088..386bcbdd429 100644 Binary files a/end-to-end-test/remote/screenshots/reference/fusion_filter_filter_study_from_url_element_chrome_1600x1000.png and b/end-to-end-test/remote/screenshots/reference/fusion_filter_filter_study_from_url_element_chrome_1600x1000.png differ diff --git a/end-to-end-test/remote/screenshots/reference/loads_a_virtual_study_element_chrome_1600x1000.png b/end-to-end-test/remote/screenshots/reference/loads_a_virtual_study_element_chrome_1600x1000.png index 2557d30ac57..f77072c7dc7 100644 Binary files a/end-to-end-test/remote/screenshots/reference/loads_a_virtual_study_element_chrome_1600x1000.png and b/end-to-end-test/remote/screenshots/reference/loads_a_virtual_study_element_chrome_1600x1000.png differ diff --git a/end-to-end-test/remote/screenshots/reference/loads_multiple_studies_with_treatments_tables_element_chrome_1600x1000.png b/end-to-end-test/remote/screenshots/reference/loads_multiple_studies_with_treatments_tables_element_chrome_1600x1000.png index 211d5c8159e..f33e645b2a5 100644 Binary files a/end-to-end-test/remote/screenshots/reference/loads_multiple_studies_with_treatments_tables_element_chrome_1600x1000.png and b/end-to-end-test/remote/screenshots/reference/loads_multiple_studies_with_treatments_tables_element_chrome_1600x1000.png differ diff --git a/end-to-end-test/remote/screenshots/reference/plots_tab_with_structural_variant_coloring_element_chrome_1600x1000.png b/end-to-end-test/remote/screenshots/reference/plots_tab_with_structural_variant_coloring_element_chrome_1600x1000.png index e8e72a9139f..31b36e4d4c9 100644 Binary files a/end-to-end-test/remote/screenshots/reference/plots_tab_with_structural_variant_coloring_element_chrome_1600x1000.png and b/end-to-end-test/remote/screenshots/reference/plots_tab_with_structural_variant_coloring_element_chrome_1600x1000.png differ diff --git a/end-to-end-test/remote/screenshots/reference/study_view_laml_tcga_clinical_data_clicked_element_chrome_1600x1000.png b/end-to-end-test/remote/screenshots/reference/study_view_laml_tcga_clinical_data_clicked_element_chrome_1600x1000.png index abf42292500..cb24ad5ec2e 100644 Binary files a/end-to-end-test/remote/screenshots/reference/study_view_laml_tcga_clinical_data_clicked_element_chrome_1600x1000.png and b/end-to-end-test/remote/screenshots/reference/study_view_laml_tcga_clinical_data_clicked_element_chrome_1600x1000.png differ diff --git a/end-to-end-test/remote/screenshots/reference/tcga_pancancer_atlas_page_element_chrome_1600x1000.png b/end-to-end-test/remote/screenshots/reference/tcga_pancancer_atlas_page_element_chrome_1600x1000.png index e7d8fa378a1..2b0cc1b210f 100644 Binary files a/end-to-end-test/remote/screenshots/reference/tcga_pancancer_atlas_page_element_chrome_1600x1000.png and b/end-to-end-test/remote/screenshots/reference/tcga_pancancer_atlas_page_element_chrome_1600x1000.png differ diff --git a/end-to-end-test/remote/screenshots/reference/when_quickly_adding_charts,_each_chart_should_get_proper_data._element_chrome_1600x1000.png b/end-to-end-test/remote/screenshots/reference/when_quickly_adding_charts,_each_chart_should_get_proper_data._element_chrome_1600x1000.png index 4b991440a79..f967ffcd6db 100644 Binary files a/end-to-end-test/remote/screenshots/reference/when_quickly_adding_charts,_each_chart_should_get_proper_data._element_chrome_1600x1000.png and b/end-to-end-test/remote/screenshots/reference/when_quickly_adding_charts,_each_chart_should_get_proper_data._element_chrome_1600x1000.png differ diff --git a/end-to-end-test/remote/specs/core/customTabs.spec.js b/end-to-end-test/remote/specs/core/customTabs.spec.js index 216e334156f..9fc32ce2c44 100644 --- a/end-to-end-test/remote/specs/core/customTabs.spec.js +++ b/end-to-end-test/remote/specs/core/customTabs.spec.js @@ -106,6 +106,11 @@ function runTests(pageName, url, tabLocation) { $('.mainTabs').waitForDisplayed(); + if (tabLocation === 'STUDY_PAGE') { + $('i.fa-chevron-right').waitForDisplayed(); + $('i.fa-chevron-right').click(); + } + assert.equal( $('=Patient Tab').isDisplayed(), false, @@ -143,6 +148,11 @@ function runTests(pageName, url, tabLocation) { $('.mainTabs').waitForDisplayed(); + if (tabLocation === 'STUDY_PAGE') { + $('i.fa-chevron-right').waitForDisplayed(); + $('i.fa-chevron-right').click(); + } + assert.equal( $('=Hidden Tab').isDisplayed(), false, @@ -235,7 +245,8 @@ function runTests(pageName, url, tabLocation) { }; }); - $('=Async Tab').click(); + // offset to avoid overlapping elements + $('=Async Tab').click({ x: -10 }); browser.pause(1000); diff --git a/src/pages/groupComparison/ClinicalData.tsx b/src/pages/groupComparison/ClinicalData.tsx index a5be5e5a68c..80f3da4443c 100644 --- a/src/pages/groupComparison/ClinicalData.tsx +++ b/src/pages/groupComparison/ClinicalData.tsx @@ -31,7 +31,7 @@ import { isStringData, IStringAxisData, makeBoxScatterPlotData, -} from 'pages/resultsView/plots/PlotsTabUtils'; +} from 'shared/components/plots/PlotsTabUtils'; import ScrollBar from 'shared/components/Scrollbar/ScrollBar'; import { IBoxScatterPlotData } from 'shared/components/plots/BoxScatterPlot'; import { scatterPlotSize } from 'shared/components/plots/PlotUtils'; diff --git a/src/pages/groupComparison/ClinicalNumericalDataVisualisation.tsx b/src/pages/groupComparison/ClinicalNumericalDataVisualisation.tsx index 41641c018a7..6098a1c75cd 100644 --- a/src/pages/groupComparison/ClinicalNumericalDataVisualisation.tsx +++ b/src/pages/groupComparison/ClinicalNumericalDataVisualisation.tsx @@ -2,7 +2,7 @@ import BoxScatterPlot, { IBoxScatterPlotProps, toBoxPlotData, } from 'shared/components/plots/BoxScatterPlot'; -import { IBoxScatterPlotPoint } from 'pages/resultsView/plots/PlotsTabUtils'; +import { IBoxScatterPlotPoint } from 'shared/components/plots/PlotsTabUtils'; import React from 'react'; import { computed, makeObservable } from 'mobx'; import { SummaryStatisticsTable } from './SummaryStatisticsTable'; diff --git a/src/pages/groupComparison/MultipleCategoryBarPlot.tsx b/src/pages/groupComparison/MultipleCategoryBarPlot.tsx index 39b30d85fd9..ec6fa6e8dc8 100644 --- a/src/pages/groupComparison/MultipleCategoryBarPlot.tsx +++ b/src/pages/groupComparison/MultipleCategoryBarPlot.tsx @@ -31,7 +31,7 @@ import * as ReactDOM from 'react-dom'; import { Popover } from 'react-bootstrap'; import classnames from 'classnames'; import { toConditionalPrecisionWithMinimum } from 'shared/lib/FormatUtils'; -import { IStringAxisData } from 'pages/resultsView/plots/PlotsTabUtils'; +import { IStringAxisData } from 'shared/components/plots/PlotsTabUtils'; import WindowStore from 'shared/components/window/WindowStore'; export interface IMultipleCategoryBarPlotProps { diff --git a/src/pages/resultsView/ResultsViewPage.tsx b/src/pages/resultsView/ResultsViewPage.tsx index 5c0d6bc1efd..09423eeade7 100644 --- a/src/pages/resultsView/ResultsViewPage.tsx +++ b/src/pages/resultsView/ResultsViewPage.tsx @@ -22,7 +22,7 @@ import StructuralVariants from 'pages/resultsView/structuralVariant/StructuralVa import './styles.scss'; import ResultsViewOncoprint from 'shared/components/oncoprint/ResultsViewOncoprint'; import QuerySummary from './querySummary/QuerySummary'; -import PlotsTab from './plots/PlotsTab'; +import PlotsTab from 'shared/components/plots/PlotsTab'; import { MSKTab, MSKTabs } from '../../shared/components/MSKTabs/MSKTabs'; import { PageLayout } from '../../shared/components/PageLayout/PageLayout'; import autobind from 'autobind-decorator'; @@ -254,8 +254,97 @@ export default class ResultsViewPage extends React.Component< linkText={'Plots'} > ); diff --git a/src/pages/resultsView/cancerSummary/CancerSummaryContainer.tsx b/src/pages/resultsView/cancerSummary/CancerSummaryContainer.tsx index e9356ea1b92..53ee5ed98bd 100644 --- a/src/pages/resultsView/cancerSummary/CancerSummaryContainer.tsx +++ b/src/pages/resultsView/cancerSummary/CancerSummaryContainer.tsx @@ -235,11 +235,46 @@ export default class CancerSummaryContainer extends React.Component<
- - + +
- +