Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAST returns natural log, not log2FC #20

Closed
le-ander opened this issue Jun 26, 2019 · 3 comments
Closed

MAST returns natural log, not log2FC #20

le-ander opened this issue Jun 26, 2019 · 3 comments

Comments

@le-ander
Copy link
Member

le-ander commented Jun 26, 2019

I have recently checked with the MAST developers what log basis they use to report logfoldchanges in MAST because I could not find that information anywhere. (RGLab/MAST#112)

Turns out that given we provide (natural)log-normalised as an input to mast, the reported logfoldchanges are also on a natural log basis. I.e. they need to be devided by ln(2) to become log2FC.

I guess this will also be important to how you use those values in the notebook as well.

@LuckyMD
Copy link
Contributor

LuckyMD commented Jun 26, 2019

Hey!

Thanks for the update. I do have a plot that assumes they are log2 FC values. Tbh, I don't think it changes the results though. The only difference is a scaling factor on the logFC values... in the notebook the absolute values don't really matter. I will adapt this though!

@LuckyMD
Copy link
Contributor

LuckyMD commented Jun 26, 2019

will reopen this for now until it is fixed.

@LuckyMD
Copy link
Contributor

LuckyMD commented Jan 5, 2021

Updated in #58

@LuckyMD LuckyMD closed this as completed Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants