Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client crash when using protobuf3.1 #19

Open
gitgoready opened this issue Jan 17, 2017 · 2 comments
Open

Client crash when using protobuf3.1 #19

gitgoready opened this issue Jan 17, 2017 · 2 comments

Comments

@gitgoready
Copy link

compile proto files("syntax=proto3") using protobuf3.1,server run ok and got client request,client crash with Application_error(0)

@gitgoready
Copy link
Author

Acturely it's rpc_response_header_status_code_INACTIVE in rpc_channel_impl::handle_client_response

@gitgoready
Copy link
Author

Ok,it's an proto2 to proto3 error, enum default value are set to the first one, zero now. change rpcz.proto to
message rpc_response_header {
enum status_code {
OK = 0; // Done
ACTIVE = 1;
INACTIVE = 2;

and class connection_manager enum definition to
class connection_manager {
public:
enum status {
DONE = 0,
INACTIVE = 1,
ACTIVE = 2,

recompile and proto3 ok now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant