Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switching config_teagent.sh to an erb template for the config file #11

Open
drenalin23 opened this issue Mar 3, 2018 · 2 comments
Open

Comments

@drenalin23
Copy link
Contributor

This is sort of question about how things are set up. Is there a compelling reason that this cookbook install a shell script which edits /etc/te-agent.cfg, instead of just editing /etc/te-agent.cfg directly as an erb template?
Asking as we get errors on exit from the Shellout on 14.04 and if this was an erb template the file can just be directly updated without the need for a shell script.

@pcabido
Copy link
Contributor

pcabido commented Mar 5, 2018

@drenalin23 Our agent software manages the configuration file itself so depending on how this is being used there was the potential to overwrite the configuration file which isn't ideal so we opted by this approach at the time. This was done a while back so it was also being done this way in a few other places and we ended up re-using.

I think that we can improve this. We're looking into it.

@drenalin23
Copy link
Contributor Author

#12 is an example of writing the config file directly with chef.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants