Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update bit64::as.integer64 use in test #1567

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

edward-burn
Copy link
Contributor

@edward-burn edward-burn commented Dec 29, 2024

fixes #1564

@simonpcouch @hadley the check is failing for other reasons I believe - it seems that the error "vector memory limit of 16.0 Gb reached, see mem.maxVSize()" on macos came between https://github.com/tidyverse/dbplyr/actions/runs/11802007517/job/32876673073 and https://github.com/tidyverse/dbplyr/actions/runs/12089965184/job/33716160658

Copy link
Collaborator

@simonpcouch simonpcouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ha, nice catch—just a bad vector recycle. Thumbs up from me, though I'll defer to Hadley on merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

snap change for postgres
2 participants