Key background inherits panel background #5551
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix #5549.
Briefly, it sets
legend.key
to inherit frompanel.background
and eliminates thelegend.key
element from the built-in themes.This causes the key backgrounds to automatically adhere to the panel background style.
Created on 2023-11-29 with reprex v2.0.2
For many built-in themes, this was already achieved by encoding the
legend.key
element andpanel.background
seperately in the same style. With this PR, this doesn't need to happen seperately anymore.However, because the default
theme_gray()
had a slightly lighterlegend.key
thanpanel.background
, there is a noticible (but not very obvious) visual change in this theme. See attached example where the left part is the current default and the right part is the default with this PR: