From ed8896119feddc38fcf1ee028ca0eaad46ab842c Mon Sep 17 00:00:00 2001 From: robomic Date: Wed, 22 Jan 2025 10:57:35 +0100 Subject: [PATCH] avoid race condition by returning by value --- external/concealer/include/concealer/subscriber_wrapper.hpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/external/concealer/include/concealer/subscriber_wrapper.hpp b/external/concealer/include/concealer/subscriber_wrapper.hpp index 8247a872e3a..25270a4b62f 100644 --- a/external/concealer/include/concealer/subscriber_wrapper.hpp +++ b/external/concealer/include/concealer/subscriber_wrapper.hpp @@ -35,7 +35,8 @@ class SubscriberWrapper if constexpr (thread_safety == ThreadSafety::unsafe) { return *current_value; } else { - return *std::atomic_load(¤t_value); + const auto copy = *std::atomic_load(¤t_value); + return copy; } }