Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pd-ctl unsafe remove-failed-stores argument parsing is easy to get wrong #9033

Open
dveeden opened this issue Feb 5, 2025 · 0 comments · May be fixed by #9034
Open

pd-ctl unsafe remove-failed-stores argument parsing is easy to get wrong #9033

dveeden opened this issue Feb 5, 2025 · 0 comments · May be fixed by #9034
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@dveeden
Copy link
Contributor

dveeden commented Feb 5, 2025

Enhancement Task

This is accepted, but doesn't do what you expect it to do.

pd-ctl unsafe remove-failed-stores 1 2

It should have been this:

pd-ctl unsafe remove-failed-stores 1,2
@dveeden dveeden added the type/enhancement The issue or PR belongs to an enhancement. label Feb 5, 2025
@dveeden dveeden linked a pull request Feb 5, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

command: check for too many arguments in pd-ctl unsafe remove-failed-stores dveeden/pd
1 participant
@dveeden