-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider Transition object being a promise sublcass #95
Comments
Resolved in 83f33ba |
@jmeas no, that doesn't resolve it. That merely creates a promise like entity that decorates a rail promise, it does not create a subclass. |
Ah, gotcha 👍 |
I'm doing some issues-gardening 🍀 🌷 and stumbled upon this. Is this still an issue? if not, perhaps it can be closed? |
Yes, it is still an issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The Transition object already mimics a thenable via
then
but lackscatch
andfinally
etc, why not just make it a subclasshttps://github.com/tildeio/router.js/blob/master/lib/router/transition.js
The text was updated successfully, but these errors were encountered: