Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make label compatible with existing ones #43

Open
Mic92 opened this issue Jul 4, 2020 · 2 comments
Open

Make label compatible with existing ones #43

Mic92 opened this issue Jul 4, 2020 · 2 comments

Comments

@Mic92
Copy link
Contributor

Mic92 commented Jul 4, 2020

Our current labels start with number for priority and also have a color scheme according to priority: NixOS/nixpkgs#92249
Marvin should also follow the same scheme.

@Mic92 Mic92 changed the title Make lable compatible with existing ones Make label compatible with existing ones Jul 4, 2020
@blaggacao
Copy link
Contributor

I'd wait for GA version of marvin, since "looking official" implies stronger stability guarantees.

@timokau
Copy link
Owner

timokau commented Jul 8, 2020

I don't think it should follow that scheme. There is not much to be gained, and the priority number is a major inconvenience when handling those labels. That is especially true for labels that we want people to actively search for. They would now have to remember/look up the somewhat arbitrary number prefix and probably quote the label in the search. Additionally its nice to have a 1:1 match between the labels and the status names.

(Also, not all current nixpkgs label match that scheme.)

Colors could be added of course, I don't mind that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants