Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take check status into account #52

Open
timokau opened this issue Jul 6, 2020 · 1 comment
Open

Take check status into account #52

timokau opened this issue Jul 6, 2020 · 1 comment

Comments

@timokau
Copy link
Owner

timokau commented Jul 6, 2020

Triage could automatically set to awaiting_changes and post an appropriate message when checks failed. Assigning a reviewer could be postponed until checks succeed.

https://docs.github.com/en/github/searching-for-information-on-github/searching-issues-and-pull-requests#search-by-commit-status

@timokau
Copy link
Owner Author

timokau commented Jul 10, 2020

General idea:

  • Subscribe to check_run.
  • Reset state to awaiting_changes when a check has conclusion negative or (debatable) has conclusion Neutral and is due to a ofBorg build failure. Post a message. Suggest ways to deal with pre-existing failures (restrict platforms, mark dependencies as broken). Allow users to ignore this with a manual status override, bug suggest they try to fix the checks instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant