Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No external library dependencies. #1

Open
nanomonkey opened this issue Feb 13, 2025 · 1 comment
Open

No external library dependencies. #1

nanomonkey opened this issue Feb 13, 2025 · 1 comment

Comments

@nanomonkey
Copy link
Contributor

I think that most would agree that the search functionality in the Arduino IDE's Library Manager isn't ideal. I propose that we bundle all of the necessary libraries with the source of the repo.

We will need to updates the includes from
#include <SPI.h>
to something like
#include "src/libs/SPI/src/SPI.h"

Thoughts, concerns?

@tschudin
Copy link
Contributor

SPI.h comes with the esp32 Espressif software, in the directory (on MacOS)
~/Library/Arduino15/packages/esp32/hardware/esp32/2.0.9/libraries/SPI/src/SPI.h
thus is part of the "platform". This platform has to be installed at an outer level anyway in order to compile, even without talking about extension libraries like RadioLib or Button2 etc

For the extension libraries I have already started to collect them in
loramesh/lib/TBeam/...
or in case such a library is used by multiple boards, in
loramesh/lib/shared/...

My answer to your question thus is: distinguish platform from extension libraries, and only copy extension libraries into our source tree, and then do it in loramesh/lib/... on a per-board or shared basis

Note that over time some extension libraries can become platform libraries, as it has happened for the littleFS functionality which is now officially in the Espressif platform code base.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants