Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inconsistency of reflect.SliceHeader's field types with official reflect package #1364

Closed
mathetake opened this issue Sep 7, 2020 · 2 comments
Labels
duplicate This issue or pull request already exists

Comments

@mathetake
Copy link
Contributor

When I was working with reflect.SliceHeader of TinyGo, I found that the type of SliceHeader.{Len,Cap} is uintptr and is different from the one of Go's official implementation which is int:

is this intentional? If not, may I fix this and replace uintptr with int ?

motivation: If possible, I do not want to have separated files for Go (for testing) and Tinygo (for building) of virtually identical files

@deadprogram
Copy link
Member

Please see #1284 for a discussion about this topic.

@deadprogram deadprogram added the duplicate This issue or pull request already exists label Sep 9, 2020
@mathetake
Copy link
Contributor Author

thanks for the pointer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants