Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net.Pipe not supported #3187

Closed
dkegel-fastly opened this issue Sep 20, 2022 · 3 comments
Closed

net.Pipe not supported #3187

dkegel-fastly opened this issue Sep 20, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@dkegel-fastly
Copy link
Contributor

Looking at https://github.com/go-jose/go-jose
#2660 covers go-jose's need for reflect.

The next problem I noticed was a test needs net.Pipe:

$ cd json
$ tinygo test
# github.com/go-jose/go-jose/v3/json
stream_test.go:185:15: Pipe not declared by package net
@deadprogram deadprogram added the enhancement New feature or request label Sep 26, 2022
@dgryski dgryski added the next-release Will be part of next release label Nov 4, 2022
@johnkeates
Copy link

I did a very quick grep to see if net.Pipe is actually used directly by go-jose, but it only appears to be part of the test. Did you test other features beyond this? Or is this more of an explore-and-implement roadmap.

@dkegel-fastly
Copy link
Contributor Author

It was the barest of "what is the next low hanging fruit" kind of exploration.

@deadprogram
Copy link
Member

0.27.0 has now been released, so closing. Thank you!

@deadprogram deadprogram removed the next-release Will be part of next release label Feb 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants