Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error popup when entering wrong credentials with debug=false #39

Open
Marty opened this issue Nov 18, 2020 · 1 comment
Open

Error popup when entering wrong credentials with debug=false #39

Marty opened this issue Nov 18, 2020 · 1 comment

Comments

@Marty
Copy link

Marty commented Nov 18, 2020

Describe the bug
A popup with An error occured while trying to load this page. with the url https://forum.host.tld/auth/ldap is shown when the user enters invalid credentials.
This just happens when the forum is in debug=false.
When putting it in debug=true, this popup correctly shows LDAP error: (Authentication failed...[stacktrace].

Expected behavior
No popup and a message saying Invalid credentials.

Versions

  • Flarum version: beta.13
  • Using, or trying to install LDAP extension version/branch: v0.1.0-beta.13-5

To Reproduce

  • Install v0.1.0-beta.13-5
  • configure your AD
  • have debug=false in flarum
  • login with wrong credentials

Logs
When putting the forum in debug mode, it correctly shows:

LDAP error: (Authentication failed with these login and password.
@tituspijean
Copy link
Owner

Ah yes, it was bound to come up some day. I need some time to learn on how to trigger actual alerts/errors in Flarum. 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants