Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't account for differing port numbers in URLs #48

Open
squamous opened this issue Oct 15, 2015 · 1 comment
Open

Doesn't account for differing port numbers in URLs #48

squamous opened this issue Oct 15, 2015 · 1 comment

Comments

@squamous
Copy link

www.foo.com:8000 isn't recognised as being a subdomain of foo.com:9000.

I ran into this problem when using port-forwarding on a Vagrant machine in which I was running a project with subdomains. The problematic code is in this method and is easily resolved by disregarding the port number.

I'd be more than happy to submit a PR for this if you think this issue is valid.

@prokaktus
Copy link

Current implementation of django-subdomains is very tightly coupled with django sites framework. This is brings a lot of problems (e.g. you should explicitly create additional site in db even for local hosted sites). You can try to make a fork with fix from there:
#23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants