Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Queue implementation #2

Open
jasonjeong3 opened this issue Jun 2, 2021 · 0 comments
Open

Queue implementation #2

jasonjeong3 opened this issue Jun 2, 2021 · 0 comments

Comments

@jasonjeong3
Copy link

So while trying to understand the code, I found that there might be some issues regarding event representation in the FIFO queue manner.

My understanding of how the queue portion is tested is that the queue generation is done at the transformer level, where this line takes the event sequence and generates a queue.

However, looking at the function compute_spatial_binning, it seems that the last element is not popped when the queue is full and a new event corresponding to that location is being added. Instead, the queue just rejects the new event as can be seen in by this continue line

This method would only work if the event sequence is ordered highest timestamp(most recent)->lowest timestamp(oldest timestamp) so that the first element in the "queue" has the highest timestamp, and subsequent events having lower timestamps
Was this the case with the MVSEC dataset?

Thanks,
Jason Jeong

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant