-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor mpc-tls actors #593
Conversation
@sinui0 We talked about introducing type states. Have not yet done this. Should it be part of this PR or a follow-up PR? |
This is a good start, yeah let's put the type state refactor in a separate PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't scrutinize every line, but overall lgtm modulo a couple nits
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## lift-mpz-integration #593 +/- ##
========================================================
- Coverage 54.32% 50.86% -3.46%
========================================================
Files 192 196 +4
Lines 20487 21880 +1393
========================================================
Hits 11130 11130
- Misses 9357 10750 +1393 ☔ View full report in Codecov by Sentry. |
ci is failing, but this is expected, due to |
This PR