Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor mpc-tls actors #593

Merged
merged 13 commits into from
Oct 18, 2024
Merged

Refactor mpc-tls actors #593

merged 13 commits into from
Oct 18, 2024

Conversation

th4s
Copy link
Member

@th4s th4s commented Sep 19, 2024

This PR

  • bumps ludi dependency to the newest commit
  • rewrites mpc-tls leader and follower to use actors from ludi without macros

@th4s
Copy link
Member Author

th4s commented Sep 19, 2024

@sinui0 We talked about introducing type states. Have not yet done this. Should it be part of this PR or a follow-up PR?

@sinui0
Copy link
Member

sinui0 commented Sep 19, 2024

This is a good start, yeah let's put the type state refactor in a separate PR

@sinui0 sinui0 self-requested a review September 23, 2024 16:52
Copy link
Member

@sinui0 sinui0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't scrutinize every line, but overall lgtm modulo a couple nits

crates/tls/mpc/src/msg/mpc_tls_leader_msg.rs Outdated Show resolved Hide resolved
crates/tls/mpc/src/msg/mpc_tls_follower_msg.rs Outdated Show resolved Hide resolved
@th4s th4s changed the base branch from dev to lift-mpz-integration October 18, 2024 10:38
Copy link

codecov bot commented Oct 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 1273 lines in your changes missing coverage. Please review.

Project coverage is 50.86%. Comparing base (2042089) to head (b9cd2ac).
Report is 1 commits behind head on lift-mpz-integration.

Files with missing lines Patch % Lines
crates/tls/mpc/src/leader/actor.rs 0.00% 693 Missing ⚠️
crates/tls/mpc/src/msg/leader.rs 0.00% 244 Missing ⚠️
crates/tls/mpc/src/follower/actor.rs 0.00% 240 Missing ⚠️
crates/tls/mpc/src/msg/follower.rs 0.00% 76 Missing ⚠️
crates/tls/mpc/src/msg/mod.rs 0.00% 13 Missing ⚠️
crates/tls/mpc/src/leader/mod.rs 0.00% 4 Missing ⚠️
crates/tls/mpc/src/error.rs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@                   Coverage Diff                    @@
##           lift-mpz-integration     #593      +/-   ##
========================================================
- Coverage                 54.32%   50.86%   -3.46%     
========================================================
  Files                       192      196       +4     
  Lines                     20487    21880    +1393     
========================================================
  Hits                      11130    11130              
- Misses                     9357    10750    +1393     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@th4s
Copy link
Member Author

th4s commented Oct 18, 2024

ci is failing, but this is expected, due to aead not adapted to changes in universal_hash. Proceeding with merge into integration branch

@th4s th4s merged commit def8247 into lift-mpz-integration Oct 18, 2024
1 of 5 checks passed
@th4s th4s deleted the refactor-ludi branch October 18, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants