Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with Time Signature #5

Open
Balthov60 opened this issue Feb 22, 2022 · 0 comments
Open

Issue with Time Signature #5

Balthov60 opened this issue Feb 22, 2022 · 0 comments

Comments

@Balthov60
Copy link

Balthov60 commented Feb 22, 2022

Hi !
For some reason you transform the denominator of time signature to it's log2 value
But when you compute the user friendly time signature you don't revert the denominator correctly, you compute pow($logDenominator, 2) instead of pow(2, $logDenominator)

// Constructor
parent::__construct(array($numerator, log($denominator, 2), $metronomePulse, $thirtySecondNotesPerQuarterNote));

// Time signature computation
public static function getTimeSignature($numerator, $logarithmicDenominator) {
	return $numerator . '/' . pow($logarithmicDenominator, 2);
}

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant