Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tree view shall remain visible when scrolling #27

Open
rkiss opened this issue Nov 12, 2018 · 2 comments
Open

Tree view shall remain visible when scrolling #27

rkiss opened this issue Nov 12, 2018 · 2 comments

Comments

@rkiss
Copy link

rkiss commented Nov 12, 2018

Google Chrome version: 70.0.3538.67 (Official Build) (64-bit)
GitLabTree version: 1.0.1

While scrolling vertically in the merge view the gitlab tree shall remain visible. Currently it does not so switching to new files implying scroll vertically to top of the window.

@tomasbonco
Copy link
Owner

Hi! This is intended behavior, as list of files might be huge (100+ easily), so it can be longer then a screen height. I didn't wanted to have separate scrollbars for tree and diff.

This is a second time I hear this request. If they keep coming, I will rethink how it works. PR's are always welcome too.

Tomas

@rkiss
Copy link
Author

rkiss commented Nov 22, 2018

I see, having a second scrollbar is not desired indeed.
Still, I think there is a way.
If the tree window is taller then the available space then during scroll it shall scroll but only enough to make the bottom part of it fully visible.
As a best practice, a merge request shall not have hundreds of files. That could happen indeed but hopefully not very often.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants