Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KnihyDobrovský - BF scraper vrací originalPrice správně, ale běžný scraper ne #2539

Open
MartinaGelnerova opened this issue Oct 15, 2024 · 6 comments
Labels

Comments

@MartinaGelnerova
Copy link
Collaborator

prosím v běžném scrapu ukládat stejnou originalPrice jako bere BF scrape tj "Nejnižší cena před akcí"

např: https://www.knihydobrovsky.cz/papirnictvi/pilot-frixion-0-7-mm-ruzova-668523

<span class="price-before tooltip-js" data-title="Uvedená cena je nejnižší prodejní cenou zboží v období 30 dní před začátkem slevové akce.">
            Nejnižší cena před akcí: 89&nbsp;Kč
        </span>

image

@MartinaGelnerova
Copy link
Collaborator Author

assigned to @JJetmar

@JJetmar
Copy link
Contributor

JJetmar commented Oct 23, 2024

@MartinaGelnerova

fixed in PR #2567

tested locally

The issue is that for daily scraping it never reach the detail and takes the prices only from lists/overviews but there was originally no implementation for getting originalPrice from the lists/overview.

@MartinaGelnerova
Copy link
Collaborator Author

@rarous pls merge

@rarous
Copy link
Collaborator

rarous commented Oct 23, 2024

@MartinaGelnerova pls build&check

@MartinaGelnerova
Copy link
Collaborator Author

works fine, thank you, closing the issue.

@MartinaGelnerova
Copy link
Collaborator Author

@JJetmar not getting min30back price for this product (only extension returns min30back as originalPrice) - can you please check?
https://www.knihydobrovsky.cz/kniha/vesmirnicek-467620371
image

@rarous rarous removed the bug label Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants