Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update animation to show on black background [hbar 2000] #13

Open
topshef opened this issue Oct 29, 2020 · 11 comments
Open

update animation to show on black background [hbar 2000] #13

topshef opened this issue Oct 29, 2020 · 11 comments
Assignees
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@topshef
Copy link
Owner

topshef commented Oct 29, 2020

Context:

The following amimated button has a nice sparkly animation when you click it:
https://kpay.live/1clicktip/demo_animated_button/?amount=0.3&unit=hbar&recipientId=0.0.26938

But when presented on a black background, the animation hardly shows, eg:
https://kpay.live/1clicktip/demo_video/?amount=0.1&unit=hbar&recipientId=0.0.28224&vid=GzmS4p3jXvs

Task: to update the colours etc (coin3.css, coin3.js ?) so that the animation shows up well on a black background

@topshef topshef added good first issue Good for newcomers help wanted Extra attention is needed labels Oct 29, 2020
@rashadatjou
Copy link
Contributor

I would like to solve this if it's still active ?

@topshef
Copy link
Owner Author

topshef commented Oct 29, 2020

@Denpex thank you, yes please I have assigned you :-)

@rashadatjou
Copy link
Contributor

@topshef awesome :D

@topshef
Copy link
Owner Author

topshef commented Oct 30, 2020

@Denpex thanks so much for PR #14
The parameterization is cool, here is an example with red and blue:
https://kpay.live/scratchpad/animatedbuttons/mediumclap/blackbackground/coin3.html

:root {
--background-color: black;
--particle-color: red;
--main-color: #0000ff;

--particle-opacity: 1;
}
image

A follow-up might be to set the circle colour (currently white) as a parameter, and also to delay the colour fading so that colours remain bright for a short while.

@topshef
Copy link
Owner Author

topshef commented Oct 30, 2020

@Denpex do you have a Hedera account for tips, or can you open one? See #5

@rashadatjou
Copy link
Contributor

@topshef I will create another pull request and separate the circle and any other color into their own variable. I don't have a Hedera account but will create one and send it to you, thanks beforehand for the tip!

@rashadatjou
Copy link
Contributor

@topshef I am participating in this years hacktoberfest and I would really appreciate it if you would add the topic hacktoberfest & hacktoberfest-accept to this issue. I am going to create another pull request later today to separate all the colors into their own variables.

@topshef
Copy link
Owner Author

topshef commented Oct 31, 2020

@Denpex sure yes i'll try to do that now, i believe that's at the repo level. Thanks for your help :-)
[edit: hacktoberfest & hacktoberfest-accepted topics now added]

@JonathanDn
Copy link

Great stuff good job @Denpex ! :)

@topshef
Copy link
Owner Author

topshef commented Nov 17, 2020

@Denpex thanks again, we note we haven't tipped you yet... let me know when you have a Hedera account and we'll send it over. You can open an account directly within the following app, no KYC required: https://ivy.world

There are other options if you're crypto-savvy: https://help.hedera.com/hc/en-us/categories/360000099958-HBAR-Wallets

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants