Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate shiki-es dep to shikiji #76

Closed
josecelano opened this issue May 30, 2024 · 3 comments
Closed

Migrate shiki-es dep to shikiji #76

josecelano opened this issue May 30, 2024 · 3 comments
Assignees
@grmbyrn
Labels
Dependencies Related to Dependencies no-issue-activity
Milestone
v3.1.0

Comments

@josecelano
Copy link
Member

josecelano commented May 30, 2024 •
edited
Loading

https://www.npmjs.com/package/shiki-es package has been deprecated. Migrate to https://github.com/antfu/shikiji

image
@josecelano josecelano added the Dependencies Related to Dependencies label May 30, 2024
@josecelano josecelano changed the title Migrate shikiji dep to shikiji Migrate shiki-es dep to shikiji May 30, 2024
@grmbyrn grmbyrn self-assigned this Jun 4, 2024
@grmbyrn
Copy link
Collaborator

grmbyrn commented Jun 4, 2024

Hi @josecelano I've been working on how to migrate from shiki-es to shikiji as recommended. I have found that shinjiki is also deprecated as both have been merged back into Shiki 1. However, I think that the warning is coming from Histoire and not from our implementation of it.

I checked the Histoire repo and found that a PR was made to migrate it in February but it's not passing Nuxt 3 tests so hasn't been merged.

@josecelano
Copy link
Member Author

Hi @josecelano I've been working on how to migrate from shiki-es to shikiji as recommended. I have found that shinjiki is also deprecated as both have been merged back into Shiki 1. However, I think that the warning is coming from Histoire and not from our implementation of it.

I checked the Histoire repo and found that a PR was made to migrate it in February but it's not passing Nuxt 3 tests so hasn't been merged.

OK @grmbyrn we can wait until it's merged.

@josecelano josecelano transferred this issue from torrust/torrust-website-v1 Oct 3, 2024
@josecelano josecelano added this to the v3.1.0 milestone Oct 4, 2024
@grmbyrn grmbyrn mentioned this issue Nov 25, 2024
Merged
josecelano added a commit that referenced this issue Nov 25, 2024
@josecelano
Merge #125: contributor articles not appearing on contributor page
6c78abc 
d4458bd fix check error (Graeme Byrne)
270b368 fix lint error (Graeme Byrne)
59b8ec9 contributor articles not appearing on contributor page (Graeme Byrne)

Pull request description:

  * `routes/contributor/+layout.server.ts` wasn't accessing data from `routes/api` which had been set up to facilitate the change from `routes/(blog)` to `routes/blog`. This was causing the contributor's articles not to be shown on their page as detailed [here](#123). I made this data accesible to `routes/contributor` by adding the code below to `routes/contributor/+layout.server.ts`

  ```
  export const load = async ({ fetch }) => {
  const response = await fetch(`/api`);
  const posts = await response.json();

  return {
  posts
  };
  };
  ```
  * Replaced deprecated [Shijiki](https://github.com/antfu/shikiji) and [shiki-es](https://github.com/pi0/shiki-es) with [Shiki](https://github.com/shikijs/shiki) as mentioned [here](#76).

ACKs for top commit:
  josecelano:
    ACK d4458bd

Tree-SHA512: 5d2a6b089827349489e3cb944a49ee6258d12c834e2af3e007e36150ba97f8ab82b49ee19fd7756cc1dae9a52104247c0630470ee85c1ceacb29affd242bd963
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2024

Stale issue message

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@grmbyrn grmbyrn

Labels
Dependencies Related to Dependencies no-issue-activity
Projects
None yet
Milestone
v3.1.0
Development

No branches or pull requests
2 participants
@josecelano @grmbyrn