From ab8b5ef926e7d86ac3e7ce892ce137091febfe6b Mon Sep 17 00:00:00 2001 From: JunSeong Date: Tue, 7 Jan 2025 23:26:07 +0900 Subject: [PATCH 1/2] =?UTF-8?q?fix:=20=ED=81=B0=20=EC=88=AB=EC=9E=90=20?= =?UTF-8?q?=EB=B3=80=ED=99=98=EC=8B=9C=20=EB=B6=88=ED=95=84=EC=9A=94?= =?UTF-8?q?=ED=95=9C=20=EB=8B=A8=EC=9C=84=20=EC=A0=9C=EA=B1=B0?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- src/numberToHangul/numberToHangul.spec.ts | 2 ++ src/numberToHangul/numberToHangul.ts | 5 ++++- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/src/numberToHangul/numberToHangul.spec.ts b/src/numberToHangul/numberToHangul.spec.ts index 6fa1b1ea..9b52da0a 100644 --- a/src/numberToHangul/numberToHangul.spec.ts +++ b/src/numberToHangul/numberToHangul.spec.ts @@ -5,6 +5,8 @@ describe('numberToHangul', () => { expect(numberToHangul(210_000)).toBe('이십일만'); expect(numberToHangul(12_345)).toBe('일만이천삼백사십오'); expect(numberToHangul(123_456_780)).toBe('일억이천삼백사십오만육천칠백팔십'); + expect(numberToHangul(100_000_000)).toBe('일억'); + expect(numberToHangul(1_000_000_000_000)).toBe('일조'); }); test('공백 포함 변환', () => { diff --git a/src/numberToHangul/numberToHangul.ts b/src/numberToHangul/numberToHangul.ts index d5df4ece..901a8673 100644 --- a/src/numberToHangul/numberToHangul.ts +++ b/src/numberToHangul/numberToHangul.ts @@ -16,7 +16,10 @@ export function numberToHangul(input: number, options?: { spacing?: boolean }): while (remainingDigits.length > 0) { const currentPart = remainingDigits.slice(-4); - koreanParts.unshift(`${numberToKoreanUpToThousand(Number(currentPart))}${HANGUL_DIGITS[placeIndex]}`); + const koreanNumber = numberToKoreanUpToThousand(Number(currentPart)); + if (koreanNumber !== '') { + koreanParts.unshift(`${koreanNumber}${HANGUL_DIGITS[placeIndex]}`); + } remainingDigits = remainingDigits.slice(0, -4); placeIndex++; From d3f612a2801182ef3bb64ecabda85aaaebbc0049 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=EB=B0=95=EC=B0=AC=ED=98=81?= Date: Thu, 9 Jan 2025 01:09:04 +0900 Subject: [PATCH 2/2] Create curly-cycles-work.md --- .changeset/curly-cycles-work.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/curly-cycles-work.md diff --git a/.changeset/curly-cycles-work.md b/.changeset/curly-cycles-work.md new file mode 100644 index 00000000..b2050fc7 --- /dev/null +++ b/.changeset/curly-cycles-work.md @@ -0,0 +1,5 @@ +--- +"es-hangul": minor +--- + +fix: numberToHangul로 큰 숫자 변환시 불필요한 단위 제거