Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug Overlay too dark #106

Open
JustAlittleWolf opened this issue Sep 8, 2023 · 3 comments
Open

Debug Overlay too dark #106

JustAlittleWolf opened this issue Sep 8, 2023 · 3 comments

Comments

@JustAlittleWolf
Copy link
Contributor

Hello, the debug overlay is way darker than the vanilla one (left buffer OFF, right buffer ON):

This was not an issue in exordium 1.1.4. Could this be due 568737d?

@tr7zw
Copy link
Owner

tr7zw commented Sep 8, 2023

This could be a result of rendering with the shader(rendering up to 8 textures at the same time in one render call). This was my first time working with hlsl shader code, and the blending of the alpha values is not as straightforward as expected https://github.com/tr7zw/Exordium/blob/1.20/Shared/src/main/resources/assets/minecraft/shaders/core/position_multi_tex.fsh . I'd say this is not a major issue, but a nice to fix if anyone knows how.

For reference, some indev screenshots of me fighting with the blending:
These should have been the same colors:
grafik
grafik
grafik
grafik
Kinda nuking the alpha of the scoreboard with the vignette:
grafik

@JustAlittleWolf
Copy link
Contributor Author

Oh right I see, that's a little more complicated to fix then

@tr7zw
Copy link
Owner

tr7zw commented Sep 8, 2023

(Potentially the entire color could also be off, since the f3 gets rendered onto an empty texture. But that texture must have a color, even when its 100% transparent, afaik it should be black, but maybe having it white would be more correct, idk?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants