Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't parse ticket description on every comment #7

Open
toebu opened this issue Mar 18, 2015 · 3 comments
Open

Don't parse ticket description on every comment #7

toebu opened this issue Mar 18, 2015 · 3 comments
Labels

Comments

@toebu
Copy link
Contributor

toebu commented Mar 18, 2015

It seems like the main ticket description is parsed for @mentions on every comment. This means if the ticket description contains "@dude" the "dude" will be added as a CC every time someone comments, event if the comment doesn't mention the dude at all.
It should only parse the ticket description on creation of the ticket.

@CaptSpot CaptSpot added the bug label Mar 18, 2015
@rjollos
Copy link
Member

rjollos commented Mar 18, 2015

You'll also want to parse the description when it is edited.

@toebu
Copy link
Contributor Author

toebu commented Apr 10, 2015

Not sure if that's the best thing to do. Maybe you were mentioned when the ticket was created, then you removed yourself from the CC. If now someone changes a little detail in the description, it would be annoying to get added to the CC again.

@rjollos
Copy link
Member

rjollos commented Mar 22, 2017

Consider using ITicketChangeListener and sending a notification rather than manipulating the CC list. See TracMention for an example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants