Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot cancel displaying public key on T1 #3043

Closed
komret opened this issue May 30, 2023 · 5 comments · Fixed by #4480
Closed

Cannot cancel displaying public key on T1 #3043

komret opened this issue May 30, 2023 · 5 comments · Fixed by #4480
Assignees
Labels
bug Something isn't working as expected low hanging fruit Simple, quick task. T1B1 legacy Trezor One

Comments

@komret
Copy link
Contributor

komret commented May 30, 2023

Describe the bug
I cannot cancel displaying XPUB on screen of T1. Displaying it on Trezor is an upcoming feature in Suite.

Firmware version and revision
1.12.1, 1eb0eb9

Desktop/smartphone setup (please complete the following information):
T1 (works fine on TT)

To Reproduce
Steps to reproduce the behavior:

  1. trezorctl btc get-descriptor -n 0 -d
  2. Click the left button - nothing happens

Expected behavior
Public key is not displayed anymore after clicking "Cancel"

Screenshot
Screenshot 2023-05-30 at 13 04 16

@komret komret added the bug Something isn't working as expected label May 30, 2023
@matejcik
Copy link
Contributor

presumably it's the "cancel" text that is wrong?
(the button takes you to the next part of XPUB, then to address, then to QR, etc., correct?)

@komret
Copy link
Contributor Author

komret commented May 30, 2023

I updated the screenshot, the previous picture was confusing, sorry. The right button shows the second part of the pubkey and then hides it, as expected. The left (cancel) button does nothing.

Also, no option to show the QR code. I'd expect either hiding the pubkey on cancel or replacing the cancel button with QR code button, same as when displaying a receive address.

@Hannsek
Copy link
Contributor

Hannsek commented Dec 3, 2024

we should replace the cancel button with QR code button.

@romanz romanz self-assigned this Jan 8, 2025
romanz added a commit that referenced this issue Jan 8, 2025
romanz added a commit that referenced this issue Jan 8, 2025
Using similar layout to `fsm_layoutAddress`.

Fixes #3043.
romanz added a commit that referenced this issue Jan 8, 2025
Similar layout to `fsm_layoutAddress` is used.

Fixes #3043.
romanz added a commit that referenced this issue Jan 8, 2025
Similar layout to `fsm_layoutAddress` is used.

Fixes #3043.
romanz added a commit that referenced this issue Jan 8, 2025
Similar layout to `fsm_layoutAddress` is used.

Fixes #3043.
@romanz
Copy link
Contributor

romanz commented Jan 8, 2025

@Hannsek could you please take a look at #4480 (comment)?
I'll be happy to hear your opinion.

romanz added a commit that referenced this issue Jan 9, 2025
Similar layout to `fsm_layoutAddress` is used.

Fixes #3043.
@romanz romanz closed this as completed in 367ba7c Jan 9, 2025
@bosomt
Copy link

bosomt commented Jan 23, 2025

QA OK

  • 2 buttons QR Code and Confirm
  • When QR code is rendered its possible to go back via left button ✅

a920b92
firmware-T1B1-1.13.0-a920b92.bin

@bosomt bosomt moved this to ✅ Approved in Firmware Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working as expected low hanging fruit Simple, quick task. T1B1 legacy Trezor One
Projects
Status: Approved
Development

Successfully merging a pull request may close this issue.

6 participants