-
-
Notifications
You must be signed in to change notification settings - Fork 678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot cancel displaying public key on T1 #3043
Comments
presumably it's the "cancel" text that is wrong? |
I updated the screenshot, the previous picture was confusing, sorry. The right button shows the second part of the pubkey and then hides it, as expected. The left (cancel) button does nothing. Also, no option to show the QR code. I'd expect either hiding the pubkey on cancel or replacing the cancel button with QR code button, same as when displaying a receive address. |
we should replace the cancel button with |
Using similar layout to `fsm_layoutAddress`. Fixes #3043.
Similar layout to `fsm_layoutAddress` is used. Fixes #3043.
Similar layout to `fsm_layoutAddress` is used. Fixes #3043.
Similar layout to `fsm_layoutAddress` is used. Fixes #3043.
@Hannsek could you please take a look at #4480 (comment)? |
Similar layout to `fsm_layoutAddress` is used. Fixes #3043.
QA OK
a920b92 |
Describe the bug
I cannot cancel displaying XPUB on screen of T1. Displaying it on Trezor is an upcoming feature in Suite.
Firmware version and revision
1.12.1, 1eb0eb9
Desktop/smartphone setup (please complete the following information):
T1 (works fine on TT)
To Reproduce
Steps to reproduce the behavior:
trezorctl btc get-descriptor -n 0 -d
Expected behavior
Public key is not displayed anymore after clicking "Cancel"
Screenshot
![Screenshot 2023-05-30 at 13 04 16](https://private-user-images.githubusercontent.com/42465546/241947196-f471a9df-3890-4404-8e21-c056589349ac.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1MzE0MzksIm5iZiI6MTczOTUzMTEzOSwicGF0aCI6Ii80MjQ2NTU0Ni8yNDE5NDcxOTYtZjQ3MWE5ZGYtMzg5MC00NDA0LThlMjEtYzA1NjU4OTM0OWFjLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE0VDExMDUzOVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTEzZGQ1M2NjZjEyMTljZTUyYmI0OGE0MTY4ODA0Y2NhODA1OTE3YWY4NjZlMDk0ZmIyYmEyNDJjNTJmMmU3NjAmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.vvYnOdmsD6qCZe0ka38sMLtZT9D3f2E3eoUNg3_fiFw)
The text was updated successfully, but these errors were encountered: