Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solana Associated Token Account Program with data [0] #4387

Open
martykan opened this issue Nov 26, 2024 · 1 comment
Open

Solana Associated Token Account Program with data [0] #4387

martykan opened this issue Nov 26, 2024 · 1 comment
Labels
bug Something isn't working as expected

Comments

@martykan
Copy link
Member

Describe the bug
When calling the Solana instruction for Create in Associated Token Account Program, FW expects data: [], eg. instruction_id = None in terms of instructions.py.

However it should also accept data: [0] (eg. instruction_id = 0), this is what the official Solana program JS library sends.
Currently this is seen as an unknown instruction.

Firmware version and revision
2.8.3

Additional context
A quick way to fix this might be duplicating the instruction in defs/solana/programs.json, once with id: null and a new one with id: 0.

@martykan martykan added the bug Something isn't working as expected label Nov 26, 2024
@matejcik
Copy link
Contributor

oh. oh Solana. never change 🖤
(by which I mean, totally, do change, change as soon as you can, this is :headdesk:)

we specifically talked about this, and asked: so is instruction 0 different from empty instruction?
and the answer seems to be IT FUCKING DEPENDS everyone is just doing what they feel like at the moment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working as expected
Projects
Status: No status
Development

No branches or pull requests

2 participants