You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
When calling the Solana instruction for Create in Associated Token Account Program, FW expects data: [], eg. instruction_id = None in terms of instructions.py.
However it should also accept data: [0] (eg. instruction_id = 0), this is what the official Solana program JS library sends.
Currently this is seen as an unknown instruction.
Firmware version and revision
2.8.3
Additional context
A quick way to fix this might be duplicating the instruction in defs/solana/programs.json, once with id: null and a new one with id: 0.
The text was updated successfully, but these errors were encountered:
oh. oh Solana. never change 🖤
(by which I mean, totally, do change, change as soon as you can, this is :headdesk:)
we specifically talked about this, and asked: so is instruction 0 different from empty instruction?
and the answer seems to be IT FUCKING DEPENDS everyone is just doing what they feel like at the moment
Describe the bug
When calling the Solana instruction for Create in Associated Token Account Program, FW expects
data: []
, eg.instruction_id = None
in terms ofinstructions.py
.However it should also accept
data: [0]
(eg.instruction_id = 0
), this is what the official Solana program JS library sends.Currently this is seen as an unknown instruction.
Firmware version and revision
2.8.3
Additional context
A quick way to fix this might be duplicating the instruction in
defs/solana/programs.json
, once withid: null
and a new one withid: 0
.The text was updated successfully, but these errors were encountered: