Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle the limitations for 1 packet per signature #61

Open
2 tasks
spalmer25 opened this issue Mar 4, 2024 · 0 comments
Open
2 tasks

Handle the limitations for 1 packet per signature #61

spalmer25 opened this issue Mar 4, 2024 · 0 comments
Labels
new-baking-app question Further information is requested

Comments

@spalmer25
Copy link
Collaborator

spalmer25 commented Mar 4, 2024

From #50 (comment)

On one side, an index parameter is required for the SIGN instruction:

  • 0x01: to indicate that the packet does not contain all the data and that other packets will be needed to get all the data.
  • 0x81: to indicate that no other packet will be needed to obtain all the data.

On the other side, a condition tells that requests to sign data in more than one packet will be refused. Probably because of the parsing of consensus operations/blocks.

These two information are conflicting

TODO

Please create an issue regarding the limitations for 1 packet per block. We can investigate later if this limitation would restrict the baking once we add more features (like adaptive issuance, slashing) in single signature.
Add all the relevant information in the issue details.

  • Fix the conflicting information by:

    • Either change the parsing of consensus operations/blocks and allow multiple packets.
    • Or remove the dependency on 0x01/0x81 indexes and always sign a single packet.
    • Or other proposals
  • Change the doc/apdu.md file

@spalmer25 spalmer25 added question Further information is requested new-baking-app labels Mar 4, 2024
@spalmer25 spalmer25 added this to the Baking app upgrade milestone Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-baking-app question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant