From 878a24649562e3fb01ab6b07da73f9bbc643c9f9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C5=81ukasz=20Osipiuk?= Date: Thu, 28 May 2020 14:09:09 +0200 Subject: [PATCH] Use UNNECESSARY as default rounding mode Major motivation for the change is fact that UNNECESSARY rounding mode is more conservative (safer) than HALF_UP. --- .../src/main/java/io/prestosql/plugin/oracle/OracleConfig.java | 2 +- .../test/java/io/prestosql/plugin/oracle/TestOracleConfig.java | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/presto-oracle/src/main/java/io/prestosql/plugin/oracle/OracleConfig.java b/presto-oracle/src/main/java/io/prestosql/plugin/oracle/OracleConfig.java index de21ac3d92e8..40710e9157f3 100644 --- a/presto-oracle/src/main/java/io/prestosql/plugin/oracle/OracleConfig.java +++ b/presto-oracle/src/main/java/io/prestosql/plugin/oracle/OracleConfig.java @@ -27,7 +27,7 @@ public class OracleConfig { private boolean synonymsEnabled; private Integer defaultNumberScale; - private RoundingMode numberRoundingMode = RoundingMode.HALF_UP; + private RoundingMode numberRoundingMode = RoundingMode.UNNECESSARY; @NotNull public boolean isSynonymsEnabled() diff --git a/presto-oracle/src/test/java/io/prestosql/plugin/oracle/TestOracleConfig.java b/presto-oracle/src/test/java/io/prestosql/plugin/oracle/TestOracleConfig.java index 258ea587ffba..0dad3433f374 100644 --- a/presto-oracle/src/test/java/io/prestosql/plugin/oracle/TestOracleConfig.java +++ b/presto-oracle/src/test/java/io/prestosql/plugin/oracle/TestOracleConfig.java @@ -35,7 +35,7 @@ public void testDefaults() assertRecordedDefaults(recordDefaults(OracleConfig.class) .setSynonymsEnabled(false) .setDefaultNumberScale(null) - .setNumberRoundingMode(RoundingMode.HALF_UP)); + .setNumberRoundingMode(RoundingMode.UNNECESSARY)); } @Test