Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize volume integral kernels for shock capturing (less common use) #120

Merged
merged 7 commits into from
Jan 23, 2025

Conversation

huiyuxie
Copy link
Member

@huiyuxie huiyuxie commented Jan 21, 2025

The original volume integral kernels for shock capturing is not good in performance. This PR will optimize them.

The possible tasks include:

  • Optimize directly on the original kernels (larger size, less common use)
  • Tests the above kernels

EDIT: This will also address #74.

@huiyuxie huiyuxie self-assigned this Jan 21, 2025
@huiyuxie huiyuxie added the performance Improve performance label Jan 21, 2025
@huiyuxie huiyuxie changed the title Optimize volume integral kernels for shock capturing Optimize volume integral kernels for shock capturing (less common use) Jan 22, 2025
@huiyuxie
Copy link
Member Author

Optimizing for both frequent and less common use cases is too much for one PR, so it will be split into two PRs (the next one will come after this one).

@huiyuxie huiyuxie merged commit 3841a82 into main Jan 23, 2025
7 checks passed
@huiyuxie huiyuxie deleted the optimize branch January 23, 2025 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Improve performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant