-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Example for Icon parameter for Application Launcher #35
Comments
FWIW I'm personally having problems setting an icon. I would also appreciate a working example 😉 |
The path you should place your SVG icon is For those who use Zero to JupyterHub, you can add an icon (or any file) to JupyterLab instances by using the |
Hi there, I also spent a bit of time to figure out that the icon option needed to be an svg file. I tried to set a png file as icon and just could set an icon after find this issue. A suggestion would be to add this information in usage.rst file. Also, I could not set a remote svg file, just a local one. I placed my jp_app_launcher.yaml file on the same directory I run jupyterlab. Here is the content of my file.
|
Thank @luanabeckerdaluz for your info. A PR updating the documentation is very welcome! |
Hi there,
Great plugin. I spent quite a bit of time trying to figure out the icon option for a custom application launcher.
I saw in other example for extensions that you could supply an SVG string and started with that at first. Took me a while, but eventually providing a path to an SVG baked into my JupyterLab image ended up working.
Might be useful to provide an example for this in the documentation - I couldn't find it if it is actually there. I ended up grabbing the terminal SVG using Chrome debugger and saved it as an SVG and included it in my application launcher example.
Anyway, my goal was to launch a Jupyter tab to proxy through to the Spark application UI running in the Jupyter Lab container (by using a proxy plugin to expose the port via a URL). This plugin worked amazingly.
Another thing is that switching between dark and light modes affects the highlighting of the icon background for the terminal icon; i.e. the colours get inverted by some object property in the SVG. Might be useful to describe this behaviour also with the SVG icons example. I'm still figuring out how to make my Spark UI icon work correctly in both modes.
Cheers,
Berg
The text was updated successfully, but these errors were encountered: