Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

location of pre-built binaries of gr1c #37

Closed
johnyf opened this issue Jun 3, 2021 · 4 comments
Closed

location of pre-built binaries of gr1c #37

johnyf opened this issue Jun 3, 2021 · 4 comments
Assignees

Comments

@johnyf
Copy link
Member

johnyf commented Jun 3, 2021

Bintray shut down on May 1st, 2021. The CI setup script of tulip raised an error about the SHA-256 hash.

I updated tulip's CI configuration file to download gr1c from the GitHub release assets, as described in tulip-control/tulip-control#246.

I am not sure whether downloading gr1c from elsewhere than GitHub release assets would be decided (latest change to the download was in tulip commit tulip-control/tulip-control@89d7751 and also relevant is tulip commit tulip-control/tulip-control@667499b).

Assuming that gr1c will be downloaded from GitHub, a relevant change seems to be to the file:

https://github.com/tulip-control/gr1c/blob/200b70e7c0c7d47a1892d3b88cafe059ec865029/doc/api_intro.md#:~:text=bintray

(The linking syntax that I used is from the "Text Fragments" draft, because currently GitHub does not support linking to a specific line of a Markdown file.)

@slivingston slivingston self-assigned this Jun 4, 2021
@slivingston
Copy link
Member

@johnyf thanks for this careful review. I was not aware that Bintray shut down. I propose that we can put gr1c release files as assets on GitHub releases (e.g., as on v0.13.0). Actually I created #35 to automate this process.

I will update api_intro.md as you comment, and then I will close this issue.

slivingston added a commit that referenced this issue Jun 4, 2021
Following discussion at #37

[ci skip]
@slivingston
Copy link
Member

For posterity, hosting release files outside GitHub was motivated because

  1. depending on GitHub for source code and release file hosting results in a single point of failure for downloading gr1c;
  2. years ago GitHub had support for release assets but removed it, and later introduced another way to upload release assets; because of these changes, it was not clear to me that GitHub would keep "releases" as a feature indefinitely.

Today, only the first motivation above is significant. However I do not think the current benefit of redundancy justifies the cost of hosting releases with a separate provider.

@johnyf
Copy link
Member Author

johnyf commented Jun 4, 2021

@slivingston thank you for updating the documentation, and noting the motivation.

@johnyf
Copy link
Member Author

johnyf commented Sep 21, 2021

Above (#37 (comment)), I commented that GitHub does not support linking to specific lines in Markdown files. This has now changed: GitHub supports links to Markdown files. For example, the link from above would be:

Releases are posted at https://dl.bintray.com/slivingston/generic/. Pre-built

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants