-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
location of pre-built binaries of gr1c
#37
Comments
@johnyf thanks for this careful review. I was not aware that Bintray shut down. I propose that we can put gr1c release files as assets on GitHub releases (e.g., as on v0.13.0). Actually I created #35 to automate this process. I will update api_intro.md as you comment, and then I will close this issue. |
Following discussion at #37 [ci skip]
For posterity, hosting release files outside GitHub was motivated because
Today, only the first motivation above is significant. However I do not think the current benefit of redundancy justifies the cost of hosting releases with a separate provider. |
@slivingston thank you for updating the documentation, and noting the motivation. |
Above (#37 (comment)), I commented that GitHub does not support linking to specific lines in Markdown files. This has now changed: GitHub supports links to Markdown files. For example, the link from above would be: Line 14 in 200b70e
|
Bintray shut down on May 1st, 2021. The CI setup script of
tulip
raised an error about the SHA-256 hash.I updated
tulip
's CI configuration file to downloadgr1c
from the GitHub release assets, as described in tulip-control/tulip-control#246.I am not sure whether downloading
gr1c
from elsewhere than GitHub release assets would be decided (latest change to the download was intulip
commit tulip-control/tulip-control@89d7751 and also relevant istulip
commit tulip-control/tulip-control@667499b).Assuming that
gr1c
will be downloaded from GitHub, a relevant change seems to be to the file:https://github.com/tulip-control/gr1c/blob/200b70e7c0c7d47a1892d3b88cafe059ec865029/doc/api_intro.md#:~:text=bintray
(The linking syntax that I used is from the "Text Fragments" draft, because currently GitHub does not support linking to a specific line of a Markdown file.)
The text was updated successfully, but these errors were encountered: