Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replies do not show up in the activity feed anymore #142

Open
nightpool opened this issue Dec 6, 2024 · 5 comments
Open

Replies do not show up in the activity feed anymore #142

nightpool opened this issue Dec 6, 2024 · 5 comments

Comments

@nightpool
Copy link

@marcustyphoon mentioned to me that the activity feed changed how it handled replies recently, and it seems like as a side-effect of that replies no longer show up in the public API at all:

image
curl 'https://api.tumblr.com/v2/blog/nightpool.tumblr.com/notifications' \
  -H 'accept: application/json' \
  -H 'authorization: Bearer [redacted]' \

> GET /v2/blog/nightpool.tumblr.com/notifications HTTP/2
> Host: api.tumblr.com
> User-Agent: curl/8.4.0
> accept: application/json
> authorization: Bearer [redacted]
> 
< HTTP/2 200 
< server: nginx
< date: Fri, 06 Dec 2024 01:35:15 GMT
< content-type: application/json; charset=utf-8
< content-length: 35819
< vary: Accept-Encoding
< vary: Accept-Encoding
< x-rid: 844d4a776d630d37ae3552b386eec98a
< p3p: CP="Tumblr's privacy policy is available here: https://www.tumblr.com/policy/en/privacy"
< expires: Fri, 01 Jan 1990 00:00:00 GMT
< pragma: no-cache
< cache-control: no-cache, no-store, must-revalidate
< x-ua-compatible: IE=Edge,chrome=1
< strict-transport-security: max-age=31536000; preload
< alt-svc: h3=":443"; ma=86400
< 
{
  "meta": {
    "status": 200,
    "msg": "OK"
  },
  "response": {
    "notifications": [
      {
        "type": "like",
        "timestamp": 1733443394,
        "before": 1733443394,
        "unread": false,
        "target_post_id": "769069007146991616",
        "target_post_summary": "memeiversaries: December 5th is the Feast Day of...",
        "target_tumblelog_name": "nightpool",
        "target_tumblelog_uuid": "t:CVEqXVtH4qit2A7hVNy5DA",
        "from_tumblelog_name": "titaniumelemental",
        "from_tumblelog_uuid": "t:OyMT5xnxc2j2j5r22T_zGA",
        "from_tumblelog_is_adult": false,
        "followed": false,
        "target_root_post_id": "154077623082",
        "private_channel": false,
        "target_post_type": "photo",
        "post_type": "photo",
        "media_url": "https://64.media.tumblr.com/13de9901c2f1abde08b89dd48ccfa12e/tumblr_o38ewnYUQt1u5xxmto1_75sq.jpg",
        "media_url_large": "https://64.media.tumblr.com/13de9901c2f1abde08b89dd48ccfa12e/tumblr_o38ewnYUQt1u5xxmto1_75sq.jpg",
        "reblog_key": "egm2s0wS",
        "muted": false,
        "can_mute": true,
        "id": "769071141304320000"
      },
      {
        "type": "reblog_naked",
        "timestamp": 1733442006,
        "before": 1733442006,
        "unread": false,
        "target_post_id": "769069007146991616",
        "target_post_summary": "memeiversaries: December 5th is the Feast Day of...",
        "target_tumblelog_name": "nightpool",
        "target_tumblelog_uuid": "t:CVEqXVtH4qit2A7hVNy5DA",
        "from_tumblelog_name": "jenlog",
        "from_tumblelog_uuid": "t:y9MHKN5DR_l9nP6ZRM3FOQ",
        "from_tumblelog_is_adult": false,
        "followed": false,
        "target_root_post_id": "154077623082",
        "private_channel": false,
        "target_post_type": "photo",
        "post_type": "photo",
        "media_url": "https://64.media.tumblr.com/13de9901c2f1abde08b89dd48ccfa12e/tumblr_o38ewnYUQt1u5xxmto1_75sq.jpg",
        "media_url_large": "https://64.media.tumblr.com/13de9901c2f1abde08b89dd48ccfa12e/tumblr_o38ewnYUQt1u5xxmto1_75sq.jpg",
        "reblog_key": "egm2s0wS",
        "muted": false,
        "can_mute": true,
        "post_id": "769069685697314816",
        "post_tags": [],
        "id": "769069685745565697"
      },
      {
        "type": "reblog",
        "timestamp": 1733441435,
        "before": 1733441435,
        "unread": false,
        "target_post_id": "769069007146991616",
        "target_post_summary": "memeiversaries: December 5th is the Feast Day of...",
        "target_tumblelog_name": "nightpool",
        "target_tumblelog_uuid": "t:CVEqXVtH4qit2A7hVNy5DA",
        "from_tumblelog_name": "somahind",
        "from_tumblelog_uuid": "t:gki_QotjVvBy-v6VVHEeMQ",
        "from_tumblelog_is_adult": false,
        "followed": true,
        "target_root_post_id": "154077623082",
        "private_channel": false,
        "target_post_type": "photo",
        "post_type": "photo",
        "media_url": "https://64.media.tumblr.com/13de9901c2f1abde08b89dd48ccfa12e/tumblr_o38ewnYUQt1u5xxmto1_75sq.jpg",
        "media_url_large": "https://64.media.tumblr.com/13de9901c2f1abde08b89dd48ccfa12e/tumblr_o38ewnYUQt1u5xxmto1_75sq.jpg",
        "reblog_key": "egm2s0wS",
        "muted": false,
        "can_mute": true,
        "post_id": "769069087073665024",
        "added_text": "",
        "post_tags": [
          "ten years of three names in one comment"
        ],
        "id": "769069087184846848"
      },
 ...

whoops!

@nobodysuspectsthebutterfly

In addition, threaded replies don't get sent in the Discord webhook for "Send new received mentions in posts and replies to Discord". Only further down a reply thread, when it starts automatically @username-ing at the top of a comment, do they come through as a "New mention received in a reply on this post".

@cyle
Copy link
Member

cyle commented Dec 9, 2024

thanks for the report! we're rolling out a new API spec for activity items internally (not yet ready for public), and that probably caused it to break. we've ticketed this internally for a fix. there shouldn't have been any disruption for third party clients, sorry about that!

@nikitiuk0
Copy link

Hm, I can't reproduce this on my end. I used OAuth1 via postman instead of OAuth2 for simplicity, but I don't think it matters how the request is authenticated.
image

curl --location 'https://api.tumblr.com/v2/blog/testtest1321.tumblr.com/notifications?oauth_consumer_key=..&oauth_token=...&oauth_signature_method=HMAC-SHA1&oauth_timestamp=..&oauth_nonce=..&oauth_version=1.0&oauth_signature=..'
{
    "meta": {
        "status": 200,
        "msg": "OK"
    },
    "response": {
        "notifications": [
            {
                "type": "reply",
                "timestamp": 1733815684,
                "before": 1733815684,
                "unread": false,
                "target_post_id": "769461483149115392",
                "target_post_summary": "test post",
                "target_tumblelog_name": "testtest1321",
                "target_tumblelog_uuid": "t:AGF4tcUnbYHDSWSWKyYbFg",
                "from_tumblelog_name": "testest1123",
                "from_tumblelog_uuid": "t:QAKqeCiOiHNWAaMcg6c6rA",
                "from_tumblelog_is_adult": false,
                "followed": false,
                "target_root_post_id": null,
                "private_channel": false,
                "target_post_type": "regular",
                "post_type": "text",
                "reblog_key": "Q5NgPSPY",
                "muted": false,
                "can_mute": true,
                "reply_text": "@testtest1321 hi",
                "diff_to_previous": "@testtest1321 hi",
                "id": "769461515124457472"
            }
        ],
        "_links": {
            "next": {
                "href": "/v2/blog/testtest1321.tumblr.com/notifications?before=1733815684",
                "method": "GET",
                "query_params": {
                    "before": "1733815684"
                }
            }
        }
    }
}

@nikitiuk0
Copy link

Update: looks like the issue only affects threaded replies which are not being returned from the API, but if you are the post author you should still receive a normal reply notification from the API. We are looking into how to fix this

@nikitiuk0
Copy link

We have fixed the issue, you should now start seeing reply_to_comment notifications from the API for threaded replies

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants
@nightpool @cyle @nikitiuk0 @nobodysuspectsthebutterfly and others