Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't recollapse filter after every interaction #4125

Open
1 task done
nehemiagurl opened this issue Nov 28, 2023 · 2 comments · Fixed by #4130
Open
1 task done

Don't recollapse filter after every interaction #4125

nehemiagurl opened this issue Nov 28, 2023 · 2 comments · Fixed by #4130
Assignees

Comments

@nehemiagurl
Copy link

Filtered post recollapse to their filtered form after every interaction (like, boost, bookmark). This makes for a clunky experience and is genuinely just annoying as the recollapse feels unprompted.

In the vid below it happens in a hashtag feed, but it also happens in home and local, but doesn't happen in thread view.

Screen-20231128-085531-360x480.mp4

  • Tusky Version: 24 beta 1

  • Android Version: 12

  • Android Device: Galaxy A12

  • I searched or browsed the repo’s other issues to ensure this is not a duplicate.

@connyduck
Copy link
Collaborator

Thanks for reporting @nehemiagurl!

I think this could easily be fixed by not upding the filter column in TimelineDao.update. But it needs careful investigation as it might have unintended sideeffects 🤔

@Sirs0ri
Copy link
Contributor

Sirs0ri commented Dec 26, 2023

I'm still seeing this issue on the local and federated timeline, while it has been fixed and works as intended (no collapsing after and interaction) on the home timeline.

It happens for both, liking and bookmarking a toot that's been hidden through a filter, and in both cases, the filter was re-applied and the post hidden as shown in the video of the original issue.

Tusky Test 24.1 beta 1-d2cb74b6
Android 12, on an Galaxy S10e

@connyduck connyduck reopened this Dec 26, 2023
@connyduck connyduck self-assigned this Dec 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants