Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chrome Custom Tabs: Dark/Light theme defaults to browser default in Firefox #4138

Open
1 task done
Sirs0ri opened this issue Dec 2, 2023 · 2 comments
Open
1 task done

Comments

@Sirs0ri
Copy link
Contributor

Sirs0ri commented Dec 2, 2023

Hi, I noticed an issue when using Firefox as default provider for Chrome Custom Tabs:

The system UI (status bar icons, bottom gesture bar) of a CCT are always in dark mode for me (which is set as default in the browser's settings), no matter if Tusky itself is in a dark mode or not. This leads to white-on-light-blue status bar icons with very little contrast and an inconsistent color of the bottom gesture bar.

When using Chrome as CCT provider, the custom tabs correctly show in Tusky's theme, no matter what UI mode I've set in Chrome.

To reproduce:

  • Set Tusky to use a light theme, and firefox to use a dark theme
  • enable the use of Chrome Custom Tabs in Tusky's settings, set Firefox as your default browser
  • open any link from Tusky as CCT, and it'll use the browser's default theme, not Tusky's
  • repeat with Chrome as default browser, and see how the CCT now follows Tusky's theme, instead of the browser's

grafik


  • Tusky Version: stable 23.0 / nightly 24.0 beta

  • Android Version: 12

  • Android Device: Samsung SM-G970F, Galaxy S10e

  • Mastodon instance (if applicable): n.a.

  • I searched or browsed the repo’s other issues to ensure this is not a duplicate.

@Tak
Copy link
Collaborator

Tak commented Dec 4, 2023

🤔 Isn't this a problem with firefox?

@Sirs0ri
Copy link
Contributor Author

Sirs0ri commented Dec 5, 2023

I'm not familiar with the APS to customize CCTs, so I'm not sure if this is an issue with Tusky specifically or Firefox as a CCT provider.

If this issue can't be resolved on Tusky's side, feel free to close it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants