You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Distinguish between internal errors and network errors.
I want to retry calls to Twilio on network errors, but not on internal (actual) errors. The implementation isn't very consistent about what a TwilioError is, and when it should be raised.
Can we please either NOT re-raise Faraday::Error and just let it bubble up, or re-raise these errors as a new Twilio::REST::NetworkError so that consumers can better distinguish between network errors and non-network errors?
Steps to Reproduce
N/A
Code Snippet
N/A
Exception/Log
Twilio::REST::TwilioError: Failed to open TCP connection to conversations.twilio.com:443 (getaddrinfo: Temporary failure in name resolution)
Technical details:
twilio-ruby version: 6.8.0
ruby version: irrelevant
The text was updated successfully, but these errors were encountered:
hovissimo
changed the title
Distinguish between service errors and network errors.
Distinguish between internal errors and network errors.
Oct 27, 2023
Issue Summary
Distinguish between internal errors and network errors.
I want to retry calls to Twilio on network errors, but not on internal (actual) errors. The implementation isn't very consistent about what a TwilioError is, and when it should be raised.
https://github.com/search?q=repo%3Atwilio%2Ftwilio-ruby%20Twilio%3A%3AREST%3A%3ATwilioError&type=code
Can we please either NOT re-raise
Faraday::Error
and just let it bubble up, or re-raise these errors as a newTwilio::REST::NetworkError
so that consumers can better distinguish between network errors and non-network errors?Steps to Reproduce
N/A
Code Snippet
N/A
Exception/Log
Technical details:
The text was updated successfully, but these errors were encountered: