Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

What is the correct crate? #468

Open
C0D3-M4513R opened this issue Jan 9, 2025 · 2 comments · May be fixed by #469
Open

What is the correct crate? #468

C0D3-M4513R opened this issue Jan 9, 2025 · 2 comments · May be fixed by #469

Comments

@C0D3-M4513R
Copy link

C0D3-M4513R commented Jan 9, 2025 •
edited
Loading

The Readme currently says on the badge, that twitch-api2 is the crate published by this repo, but then that exact badge links to twitch-api?

Also there are no stable releases on twitch-api? So is it recommended to just use the latest rc of twitch-api or to use 0.6.1 of twitch-api2 and then have to change all the imports later to the other crate?
Edit: One could also just use twitch_api = { package = "twitch_api2", version = "0.6.1"} for the latter case. But the question still remains.
@Nerixyz
Copy link
Contributor

Nerixyz commented Jan 9, 2025

The Readme currently says on the badge, that twitch-api2 is the crate published by this repo, but then that exact badge links to twitch-api?

That's a leftover from the rename to twitch-api - twitch-api is the correct crate.

Also there are no stable releases on twitch-api? So is it recommended to just use the latest rc of twitch-api or to use 0.6.1 of twitch-api2 and then have to change all the imports later to the other crate?

If you need the new API, you need the latest rc. Even if you're using http 1.x (and related crates), it's better to use the rc, since it uses said version. There are also plans to release a stable version soon(-ish): #434. Afaik, many users (including myself) use the version from git (see also: #256).

@C0D3-M4513R
Copy link
Author

C0D3-M4513R commented Jan 9, 2025 •
edited
Loading

I just noticed that the request flag on 0.6.1 doesn't activate request on twitch_oauth2.
That's reason enough for me tbh.
I don't wanna use rust crate feature merging, if I don't have to.

C0D3-M4513R added a commit to C0D3-M4513R/twitch_api that referenced this issue Jan 9, 2025
@C0D3-M4513R
Update badge on Readme to correct repo
66c5d28 
Fixes: twitch-rs#468
@C0D3-M4513R C0D3-M4513R linked a pull request Jan 9, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update badge on Readme to correct repo C0D3-M4513R/twitch_api
2 participants
@Nerixyz @C0D3-M4513R