-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable setting up integration via ConfigFlow UI #173
Comments
If you want to I could attempt to fix this on my fork of the repo |
if you want to take a stab at it, please do ... but the biggest problem with the current yaml, there are a LOT of possible configuration options ;-) |
Yes, I have noticed so :-) |
I am briefly testing it (do not have extremely a lot of time), the following things we need to investigate/do more:
But I am happy with the current work, you have done a lot ! Thanks! |
Tomorrow I will make some changes for entity_id and name of the sensors/switches to get it a bit aligned. Also, we need to think if certain options can be removed in the UI config (which were handy/needed in YAML). Enough things to think about ;-) |
Friendly name, entity id and unique id is "not" fun ... HA links friendly name and entity id, so the renaming/aliasses/etc configuration in the YAML/UI is not useable anymore. Cleaned up also the config flow with items which should not be in the UI. I will refactor the init/run a bit more, because "certain" code starts running in the background during the config_flow run ... Which should not ;-) |
Good feedback, I'll rebase my local repo with your config_flow branch and continue to work on the reconfigure steps. |
Thanks :-) I am also working on improving the load/unload of the
DockerAPI/DockerContainerAPI (and cancelling all tasks and making the
entities unavailable ;-))
Op ma 20 jan 2025 om 11:42 schreef DanielV ***@***.***>:
… Good feedback, I'll rebase my local repo with your config_flow branch and
continue to work on the reconfigure steps.
—
Reply to this email directly, view it on GitHub
<#173 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABQASXDA33KOOCM4VU5HTPT2LTHIHAVCNFSM6AAAAABVFIAMECVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMBSGA3DCMZWGM>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
During your clean-up of config_flow.py a |
Aha :-) my mistake, if you can add it to your pull then it is re-added
Op ma 20 jan 2025 om 12:54 schreef DanielV ***@***.***>
… During your clean-up of config_flow.py a self.data.update(user_input) was
removed from async_step_containers() which makes the selection of
containers not being stored ;-)
—
Reply to this email directly, view it on GitHub
<#173 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABQASXDVZZ3HYENRTYRG5QD2LTPYBAVCNFSM6AAAAABVFIAMECVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMBSGIZDIMZYGE>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Yes, part of #178 |
With latest #179 it should be mostly done from my side unless you find something more. Also consider if you want dala318#5. It will import settings from |
I am trying to rework the entry reload/unload. At this moment when api.init() is called, it will always give an exception on an error (previously true can be returned). I haven't tested everything yet, but setup config flow is working. I am not out what the "best" approach is, so that is work in progress. |
Although the
configuration.yaml
setup works using the UI to setup the integration in much more user-friendly.(It also is an enabler to group entities to devices, https://developers.home-assistant.io/docs/device_registry_index/#automatic-registration-through-an-entity)
investigate why sometimes some containers return None from(container info no loger used at device registry)container.get_info()
for device registryasync_step_import()
method that will convertconfiguration.yaml
intoconfig_entry
. Draft proposal in Add import from configuration.yaml #181The text was updated successfully, but these errors were encountered: