-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decoupling off-canvas drawer and hamburger menu #56
Comments
The original intent was to provide off-canvas primary navigation to alleviate issues of available horizontal space as well as allow for the addition of other blocks (search, custom menus, etc). Your use case is lightly different as you want to use the off-canvas region for only additional blocks, retaining the default navigation (and mobile trigger). This means you'll need a custom trigger for the off-canvas functionality (ie. a fixed positioned button similar to this). Joel, Jens and I discussed this and we agreed that this is more specialized than we needed for a v.1. However, by editing the page.tpl, you should be able to reinstate the default mobile trigger and add a new, custom trigger (using the off-canvas trigger as a starting point). Removing the
And then adjusting this markup and placing as needed:
Hope that helps! |
Thanks for verifying the need for a new and separate trigger, which I'll start building here. Cheers! |
Our plan is to fork and build a separate flyout region on top of the develop branch. I'm also tweaking a few things in develop branch that we noticed were amiss. |
Jens asked me to clarify the functionality of the off-canvas drawer after playing around with it this week.
We assumed that we could place arbitrary blocks into the drawer and it would persist and be separate from the main menu and hamburger menu, which isn't what happens in our testing.
I've enabled the drawer region and disabled the "Use the primary menu in the off-canvas drawer" option. I've placed a menu block into the region and it all works fine. On mobile, the drawer transforms into the hamburger menu and contains the menu block. Again, I assumed the drawer would persist and the hamburger would display the main menu as it normally does.
Let us know if our assumptions are incorrect in how the drawer is designed.
The text was updated successfully, but these errors were encountered: