Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle 100+ nodes in graphql request #187

Closed
gentlementlegen opened this issue Nov 17, 2024 · 7 comments · Fixed by #255
Closed

Handle 100+ nodes in graphql request #187

gentlementlegen opened this issue Nov 17, 2024 · 7 comments · Fixed by #255

Comments

@gentlementlegen
Copy link
Member

Issue

If more than 100 get requested, it will fail and throw an error:
https://github.com/ubiquity-os-marketplace/text-conversation-rewards/blob/dee258982532d0514f7e74ff7bfd7d29c72162c7/src/helpers/get-comment-details.ts

we should loop and batch by amount of 100 nodes max to avoid a crash.

Repro steps

Run the plugin on an issue having more than a hundred comments.

@0x4007
Copy link
Member

0x4007 commented Jan 24, 2025

Is this still valid @gentlementlegen

@gentlementlegen
Copy link
Member Author

Yes it is still valid.

Copy link
Contributor

Note

The following contributors may be suitable for this task:

gentlementlegen

76% Match ubiquibot/comment-incentives#15
76% Match ubiquity-os/ubiquity-os-kernel#227

@gentlementlegen
Copy link
Member Author

/start

Copy link
Contributor

Warning! This task was created over 73 days ago. Please confirm that this issue specification is accurate before starting.
Beneficiary 0x0fC1b909ba9265A846b82CF4CE352fc3e7EeB2ED

Tip

  • Use /wallet 0x0000...0000 if you want to update your registered payment wallet address.
  • Be sure to open a draft pull request as soon as possible to communicate updates on your progress.
  • Be sure to provide timely updates to us when requested, or you will be automatically unassigned from the task.

Copy link
Contributor

Important

  • Be sure to link a pull-request before the first reminder to avoid disqualification.
  • Reminders will be sent every 2 days and 8 hours if there is no activity.
  • Assignees will be disqualified after 4 days and 16 hours of inactivity.

Copy link
Contributor

ubiquity-os-beta bot commented Jan 30, 2025

 [ 179.52 WXDAI ] 

@gentlementlegen
Contributions Overview
ViewContributionCountReward
IssueTask1150
IssueSpecification128.35
IssueComment11.17
Conversation Incentives
CommentFormattingRelevancePriorityReward
## IssueIf more than 100 get requested, it will fail and throw…
9.45
content:
  content:
    h2:
      score: 1
      elementCount: 2
    p:
      score: 0
      elementCount: 4
    a:
      score: 5
      elementCount: 1
  result: 7
regex:
  wordCount: 43
  wordValue: 0.1
  result: 2.45
1328.35
Yes it is still valid.
0.39
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 5
  wordValue: 0.1
  result: 0.39
131.17

 [ 1.17 WXDAI ] 

@0x4007
Contributions Overview
ViewContributionCountReward
IssueComment11.17
Conversation Incentives
CommentFormattingRelevancePriorityReward
Is this still valid @gentlementlegen
0.39
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 5
  wordValue: 0.1
  result: 0.39
131.17

@rndquu rndquu removed this from Development Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants