Stabilize broken test suite #350
Assignees
Comments
|
about 2 hours and is priority 3 I'd say since it's an essential part of review |
|
@Keyrxng the deadline is at Thu, Oct 24, 6:26 PM UTC |
|
| View | Contribution | Count | Reward |
|---|---|---|---|
| Issue | Task | 1 | 50 |
| Issue | Specification | 1 | 11.37 |
| Issue | Comment | 1 | 0.585 |
| Review | Comment | 19 | 0 |
Conversation Incentives
| Comment | Formatting | Relevance | Reward |
|---|---|---|---|
Cypress has been broken for the past two weeks just about and sh… | 3.79content:
content:
p:
score: 0
elementCount: 2
result: 0
regex:
wordCount: 72
wordValue: 0.1
result: 3.79
| 1 | 11.37 |
about 2 hours and is priority 3 I'd say since it's an essential … | 1.17content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 18
wordValue: 0.1
result: 1.17
| 0.5 | 0.585 |
Resolves https://github.com/ubiquity/pay.ubq.fi/issues/350Rela… | 7.5content:
content:
p:
score: 0
elementCount: 11
ul:
score: 1
elementCount: 1
li:
score: 0.5
elementCount: 3
a:
score: 5
elementCount: 1
result: 7.5
regex:
wordCount: 150
wordValue: 0
result: 0
| 0.9 | 0 |
1. It's still possible for anvil to panic and crash unrelated to… | 2content:
content:
ol:
score: 1
elementCount: 1
li:
score: 0.5
elementCount: 2
p:
score: 0
elementCount: 2
result: 2
regex:
wordCount: 45
wordValue: 0
result: 0
| 0.85 | 0 |
I can't remember exactly what the error was mate but it looked a… | 0content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 37
wordValue: 0
result: 0
| 0.7 | 0 |
it was duplicated and has two steps here doing the same thing bu… | 0content:
content:
p:
score: 0
elementCount: 2
result: 0
regex:
wordCount: 40
wordValue: 0
result: 0
| 0.6 | 0 |
Agree with you that retry should be part of `rpc-handler`… | 0content:
content:
p:
score: 0
elementCount: 2
result: 0
regex:
wordCount: 94
wordValue: 0
result: 0
| 0.8 | 0 |
you can't really do that in CI though and CI should be stable so… | 0content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 40
wordValue: 0
result: 0
| 0.75 | 0 |
Where we pull all of our data from inside `rpc-handler` … | 0content:
content:
p:
score: 0
elementCount: 7
result: 0
regex:
wordCount: 110
wordValue: 0
result: 0
| 0.65 | 0 |
I've opened a [task](https://github.com/ubiquity/rpc-handler/iss… | 5content:
content:
p:
score: 0
elementCount: 1
a:
score: 5
elementCount: 1
result: 5
regex:
wordCount: 19
wordValue: 0
result: 0
| 0.5 | 0 |
@EresDev you had this as it's own step before but that's not rig… | 0content:
content:
p:
score: 0
elementCount: 2
result: 0
regex:
wordCount: 42
wordValue: 0
result: 0
| 0.7 | 0 |
https://github.com/ubq-testing/pay.ubq.fi/actions/runs/115043441… | 0content:
content:
p:
score: 0
elementCount: 2
result: 0
regex:
wordCount: 42
wordValue: 0
result: 0
| 0.55 | 0 |
I think there is logic missing inside the cards feature that is … | 0content:
content:
p:
score: 0
elementCount: 2
result: 0
regex:
wordCount: 57
wordValue: 0
result: 0
| 0.6 | 0 |
I also investigated why `blockscan` was giving us 404 er… | 0content:
content:
p:
score: 0
elementCount: 3
result: 0
regex:
wordCount: 111
wordValue: 0
result: 0
| 0.7 | 0 |
The tests have been failing consistently for the past two weeks,… | 0content:
content:
p:
score: 0
elementCount: 3
result: 0
regex:
wordCount: 84
wordValue: 0
result: 0
| 0.85 | 0 |
QA of the tests now working:https://github.com/ubq-testing/pay… | 6.5content:
content:
p:
score: 0
elementCount: 4
hr:
score: 0
elementCount: 1
ul:
score: 1
elementCount: 1
li:
score: 0.5
elementCount: 1
a:
score: 5
elementCount: 1
result: 6.5
regex:
wordCount: 74
wordValue: 0
result: 0
| 0.8 | 0 |
I create a permit with a function that uses `cy.wrap` to… | 0content:
content:
p:
score: 0
elementCount: 2
result: 0
regex:
wordCount: 65
wordValue: 0
result: 0
| 0.6 | 0 |
I hear you. I'm sure you authored those tests but you were pulli… | 0content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 66
wordValue: 0
result: 0
| 0.65 | 0 |
Sorry your message read like I'd need to create a new one agains… | 0content:
content:
p:
score: 0
elementCount: 2
result: 0
regex:
wordCount: 40
wordValue: 0
result: 0
| 0.55 | 0 |
Hardcoded the permit as requested but I'm still using the `c… | 0content:
content:
p:
score: 0
elementCount: 4
result: 0
regex:
wordCount: 84
wordValue: 0
result: 0
| 0.75 | 0 |
https://github.com/ubq-testing/pay.ubq.fi/actions/runs/114872086… | 2content:
content:
p:
score: 0
elementCount: 3
ol:
score: 1
elementCount: 1
li:
score: 0.5
elementCount: 2
result: 2
regex:
wordCount: 136
wordValue: 0
result: 0
| 0.7 | 0 |
[ 7.682625 UUSD ]
@EresDev
Contributions Overview
| View | Contribution | Count | Reward |
|---|---|---|---|
| Review | Comment | 11 | 7.682625 |
Conversation Incentives
| Comment | Formatting | Relevance | Reward |
|---|---|---|---|
This is problematic. This means one test has a dependency on oth… | 3.79content:
content:
p:
score: 0
elementCount: 2
result: 0
regex:
wordCount: 72
wordValue: 0.1
result: 3.79
| 0.9 | 0.85525 |
Yes, tests are passing now. I ran multiple times, and one test w… | 5.18content:
content:
p:
score: 0
elementCount: 4
result: 0
regex:
wordCount: 104
wordValue: 0.1
result: 5.18
| 0.5 | 0.6525 |
any reason for removing this? | 0.39content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 5
wordValue: 0.1
result: 0.39
| 0.4 | 0.0415 |
sorting and retrying should be part of `rpc-handler`. Le… | 1.65content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 27
wordValue: 0.1
result: 1.65
| 0.8 | 0.3275 |
wss error could be just a normal failure like other rpc. I remem… | 2.1content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 36
wordValue: 0.1
result: 2.1
| 0.6 | 0.32 |
Isn't it better to use `getFastestRpcProvider`, and not … | 0.83content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 12
wordValue: 0.1
result: 0.83
| 0.7 | 0.14775 |
The retry logic helps with starting the anvil. It doesn't help a… | 2.78content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 50
wordValue: 0.1
result: 2.78
| 0.4 | 0.283 |
For CI, your solution seems useful. You can keep it then. Even… | 3.25content:
content:
p:
score: 0
elementCount: 2
result: 0
regex:
wordCount: 60
wordValue: 0.1
result: 3.25
| 0.6 | 0.485 |
This makes a precondition that test-1 must pass before test-2.… | 4.5content:
content:
p:
score: 0
elementCount: 3
result: 0
regex:
wordCount: 88
wordValue: 0.1
result: 4.5
| 0.9 | 1.0175 |
If you are referring to test "should reveal a redeem code after … | 1.49content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 24
wordValue: 0.1
result: 1.49
| 0.5 | 0.18375 |
I gave it a run. Rpc is working nicely for me. However, there ar… | 14.43content:
content:
p:
score: 0
elementCount: 4
ol:
score: 1
elementCount: 2
li:
score: 0.5
elementCount: 2
img:
score: 5
elementCount: 1
result: 8
regex:
wordCount: 134
wordValue: 0.1
result: 6.43
| 0.85 | 3.368875 |
[ 2.788 UUSD ]
@rndquu
Contributions Overview
| View | Contribution | Count | Reward |
|---|---|---|---|
| Review | Comment | 1 | 2.788 |
Conversation Incentives
| Comment | Formatting | Relevance | Reward |
|---|---|---|---|
1. Local claims seems to be working fine2. Hope this PR adds m… | 3.94content:
content:
ol:
score: 1
elementCount: 1
li:
score: 0.5
elementCount: 3
p:
score: 0
elementCount: 3
result: 2.5
regex:
wordCount: 23
wordValue: 0.1
result: 1.44
| 0.2 | 2.788 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Cypress has been broken for the past two weeks just about and should be stabilized as it's an important part of review for this CI to be green.
Another task should be made to address the problem regarding the fact that the workflow is not an active part of pull request CI as it has allowed PRs through in the last two weeks which have completely overlooked this area of development.
The text was updated successfully, but these errors were encountered: