Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Staking v2 #985

Open
Tracked by #982
rndquu opened this issue Jan 13, 2025 · 8 comments
Open
Tracked by #982

Staking v2 #985

rndquu opened this issue Jan 13, 2025 · 8 comments

Comments

@rndquu
Copy link
Member

rndquu commented Jan 13, 2025

We have the old staking contract (which still works) where users are able to stake 3CRV LP tokens and get rewards in UBQ tokens. The old staking contract has some issues:

  1. It uses 3CRV LP tokens from the old uAD/3CRV pool. We've redeployed our stable coin so now we're using UUSD instead of the deprecated uAD token.
  2. The old staking contract is unaudited
  3. There's this issue with the old staking contract

It makes sense to reimplement staking so that users were able to stake UUSD/LUSD LP tokens and get UBQ rewards. This way contributors have an incentive to keep UUSD in the UUSD/LUSD pool instead of swapping UUSD for a more liquid asset.

We've already ported staking to this diamond facet but we've never tested how it really works.

What should be done:

  1. Refactor LibStaking to match the original MaterChef implementation
  2. Cover LibStaking with unit tests
  3. Prepare on-chain migrations

The next step would be to audit the updated code and deploy to production.

@FibrinLab
Copy link
Contributor

Is this open? Or already assigned?

@SleepyDragon-foss
Copy link

/start

@Developer-Harshit
Copy link

/help

Copy link

ubiquity-os bot commented Feb 5, 2025

Available Commands

Command Description Example
/help List all available commands. /help
/ask Ask any question about the repository, issue or pull request /ask
/query Returns the user's wallet, access, and multiplier information. /query @UbiquityOS
/start Assign yourself and/or others to the issue/task. /start
/stop Unassign yourself from the issue/task. /stop
/wallet Register your wallet address for payments. Use '/wallet unset' to unlink your wallet. /wallet ubq.eth

@0x4007
Copy link
Member

0x4007 commented Feb 5, 2025

Strange that there's no response from the plugin @gentlementlegen rfc

@FibrinLab
Copy link
Contributor

/start

Copy link

ubiquity-os bot commented Feb 5, 2025

! You must be a core team member, or an administrator to start this task

@gentlementlegen
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

6 participants