From 435bc05838133985b3f7043723a462457b59ae30 Mon Sep 17 00:00:00 2001
From: Mingfei Shao <mshao1@uchicago.edu>
Date: Fri, 10 Jan 2025 12:59:16 -0600
Subject: [PATCH] fix

---
 .secrets.baseline               |  6 +++---
 tests/data/test_indexed_file.py | 11 +++--------
 2 files changed, 6 insertions(+), 11 deletions(-)

diff --git a/.secrets.baseline b/.secrets.baseline
index 92e60a158..06127e27f 100644
--- a/.secrets.baseline
+++ b/.secrets.baseline
@@ -314,14 +314,14 @@
         "filename": "tests/data/test_indexed_file.py",
         "hashed_secret": "a62f2225bf70bfaccbc7f1ef2a397836717377de",
         "is_verified": false,
-        "line_number": 467
+        "line_number": 462
       },
       {
         "type": "Secret Keyword",
         "filename": "tests/data/test_indexed_file.py",
         "hashed_secret": "c258a8d1264cc59de81f8b1975ac06732b1cf182",
         "is_verified": false,
-        "line_number": 488
+        "line_number": 483
       }
     ],
     "tests/keys/2018-05-01T21:29:02Z/jwt_private_key.pem": [
@@ -422,5 +422,5 @@
       }
     ]
   },
-  "generated_at": "2025-01-10T17:57:26Z"
+  "generated_at": "2025-01-10T18:59:11Z"
 }
diff --git a/tests/data/test_indexed_file.py b/tests/data/test_indexed_file.py
index a294b0344..164d59ed3 100755
--- a/tests/data/test_indexed_file.py
+++ b/tests/data/test_indexed_file.py
@@ -401,18 +401,13 @@ def test_get_signed_url_s3_bucket_name(mock_get_value, s3_indexed_file_location,
                     s3_indexed_file_location.parsed_url.netloc
                     == "validbucketname-netloc"
                 ):
-                    assert (
-                        "validbucketname-netloc" in result_url
-                        and "endpoint3" in result_url
-                    )
+                    # this should be in the signed URL since the bucket name with wildcard matches
+                    assert "validbucketname-netloc" in result_url
                 elif (
                     s3_indexed_file_location.parsed_url.netloc
                     == "validbucketname-alreadyvalid"
                 ):
-                    assert (
-                        "validbucketname-alreadyvalid" in result_url
-                        and "endpoint2" in result_url
-                    )
+                    assert "validbucketname-alreadyvalid" in result_url
 
 
 @pytest.mark.parametrize("supported_action", ["download"], indirect=True)