Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profiles: De-dupe Display of Email #706

Closed
wrenaria opened this issue Jan 17, 2025 · 4 comments · Fixed by #707
Closed

Profiles: De-dupe Display of Email #706

wrenaria opened this issue Jan 17, 2025 · 4 comments · Fixed by #707
Assignees
Labels
enhancement New feature or request

Comments

@wrenaria
Copy link

Feature Request

The double email displayed in Aggie Experts is sometimes a little confusing for people when they are the same address. I am wondering if it is possible to detect when there are dupes and only display a single email at the bottom of the list of roles when all associated emails are the same address.

If there are multiple unique emails for a user, then we should continue showing them as-is with one email per role. This change would only be for users where all associated emails are exactly the same.

Example

Current Suggested
Image Image
@wrenaria wrenaria added the enhancement New feature or request label Jan 17, 2025
@qjhart
Copy link
Collaborator

qjhart commented Jan 18, 2025

This seems reasonable, but there are some cases I'd like to understand. First, one reason for the current format was so that we could format vcard entries for any roles (like in the online directory; https://org.ucdavis.edu/directory-search/#/peoples-list/atwill )

If the person only has PPS roles, then their email will always be the same, so ordering all the titles together is okay. However, if they have ODR entries, then we order by the directory order (which is user specified), and in that case we could have something like:

Roles:
Chair, Library IT Department
📧 [email protected]

Director Aggie Experts
📧 [email protected]

Programmer, Library
📧 [email protected]

In that case, we want to maintain the order of the ODR, since presumably it's in order of importance. I have wondered if we could leave as is, but only use the symbol, iv the email has been shown before; as in:

Chair, Library IT Department
📧 [email protected]

Director Aggie Experts
📧 [email protected]

Programmer, Library 📧

This seems good, if we ever did add a vcard download thingy. Or also if websites matched.

Chair, Library IT Department
📧 [email protected]
🔗 https://library.ucdavis.edu/quinn

Director Aggie Experts
📧 [email protected]
🔗 https://library.ucdavis.edu/quinn

Programmer, Library 📧 🔗

@qjhart
Copy link
Collaborator

qjhart commented Jan 18, 2025

Alternatively, for ODR, we can go down list list, and combine all the roles that do have the same email, in the above example, that wouldn't change, but if my roles had a different order then they would:

Roles:
Chair, Library IT Department
Programmer, Library
📧 [email protected]

Director Aggie Experts
📧 [email protected]

@wrenaria
Copy link
Author

I think it's fine to limit the simplified email display to only apply when all emails are the same address. If there are multiple unique emails, my inclination is to show them all in the user identified order with the associated role, even when there are repeats.

YES to all these example variations:

Varied email addresses, order as specified by user:

Chair, Library IT Department
📧 [email protected]

Director Aggie Experts
📧 [email protected]

Programmer, Library
📧 [email protected]

or

Chair, Library IT Department
📧 [email protected]

Programmer, Library
📧 [email protected]

Director Aggie Experts
📧 [email protected]

All the same email:

Chair, Library IT Department

Programmer, Library

📧 [email protected]

NO to these:

Chair, Library IT Department
📧 [email protected]

Director Aggie Experts
📧 [email protected]

Programmer, Library 📧
Chair, Library IT Department
Programmer, Library
📧 [email protected]

Director Aggie Experts
📧 [email protected]

@qjhart
Copy link
Collaborator

qjhart commented Jan 22, 2025

@wrenaria the all emails is probably 95% of the entries, so this seems like good solution, and it's simple as well

@UcDust, I think we now have a complete plan;

  • Loop through all the isPreferred entries.
  • If they all have the same email, then you only display the email for the last entry.
  • If there is more than one unique email associated, then you add the email in for every entry
  • Kimmy and I didn't discuss this, but I assume you skip contacts with no email as well. Otherwise you could get this confusing example
 Chair, Library IT Department
📧 [email protected]

Programmer, Library

Director Aggie Experts
📧 [email protected]

You don't need to care whether

@qjhart qjhart removed their assignment Jan 22, 2025
UcDust added a commit that referenced this issue Jan 22, 2025
@UcDust UcDust linked a pull request Jan 27, 2025 that will close this issue
qjhart pushed a commit that referenced this issue Jan 27, 2025
* clear homepage search term and header search term after searching #704

* redirect user home when an empty search term is set on search page #704

* add grant type to grants in search results and browse pages #705

* dedupe emails under user roles #706

* clear search term in header search form #704

* grant pi label on browse/search results #705

* open-to label fix on mobile, mobile style updates for expert/grant pages to make sure watercolor image covers the heading section #709

* search page / filter ui behavior issues #703
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants