[Bug]: generateJSON is stripping trailing whitespace

[ko-synth]

Which packages did you experience the bug in?

react-tiptap

What Tiptap version are you using?

2.1.8

What’s the bug you are facing?

The issue was already reported, but went stale.

Everything from the old issue still applied. I quickly hacked a demo together, please find it here.

What browser are you using?

Chrome

Code example

No response

What did you expect to happen?

I expected to end up with the same result with both methods.

Anything to add? (optional)

No response

Did you update your dependencies?

• Yes, I’ve updated my dependencies to use the latest version of all packages.

Are you sponsoring us?

• Yes, I’m a sponsor. 💖

[hariacharya80]

Working
Edit: I mean, working on it.

[ko-synth]

Working

You mean, you couldn't reproduce?

Find a video bellow of how to go about it:

Screen.Recording.2023-10-08.at.21.48.31.mov

[hariacharya80]

@ko-synth I'm trying to work around this, I have a bit of a stop in this function:

export function generateJSON(html: string, extensions: Extensions): Record<string, any> {
  const schema = getSchema(extensions)
  const dom = elementFromString(html)

  return DOMParser.fromSchema(schema).parse(dom).toJSON()
}

While it seems that the DOMParser is using the schema from extensions to parse the JSON, I think this could be something to do with the starterkit? Not sure.. need guidance.

PS: I looked over this: https://prosemirror.net/docs/ref/#model.NodeSpec.parseDOM and https://developer.mozilla.org/en-US/docs/Web/API/DOMParser/DOMParser

[calumgunn]

Hello, if it helps --
Seems that generateJSON is removing trailing/preceding tabs, too. For example, preceding \t characters in <code> elements.

[calumgunn]

Minimal test, and result:

// Using \t, 	 or 	 to denote a tab all have the same result
const testHtml = "<code>&#9;Test after a tab.</code>";
const testJson = generateJSON(testHtml, [StarterKit]);

Produces:

Which then renders as:

[vollmond08]

editor.commands.setContent(`<p>Example Text </p>`, false, { preserveWhitespace: true, });

helped me, like a workaround

[asiraky]

@ko-synth I'm trying to work around this, I have a bit of a stop in this function:

export function generateJSON(html: string, extensions: Extensions): Record<string, any> {
  const schema = getSchema(extensions)
  const dom = elementFromString(html)

  return DOMParser.fromSchema(schema).parse(dom).toJSON()
}

While it seems that the DOMParser is using the schema from extensions to parse the JSON, I think this could be something to do with the starterkit? Not sure.. need guidance.

PS: I looked over this: https://prosemirror.net/docs/ref/#model.NodeSpec.parseDOM and https://developer.mozilla.org/en-US/docs/Web/API/DOMParser/DOMParser

The fix was to pass preserveWhitespace: true as an option to the parse function. I have submitted a PR to allow the caller to pass the options.

Edit: here is the PR #5158