Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stacking overlaping annotations #186

Closed
zouharvi opened this issue Jan 25, 2025 · 3 comments
Closed

Stacking overlaping annotations #186

zouharvi opened this issue Jan 25, 2025 · 3 comments
Labels
bug Something isn't working

Comments

@zouharvi
Copy link
Member

zouharvi commented Jan 25, 2025

There is an unexpected side effect of allowing overlapping annotations by also allowing the same error type over the same span.

Sorry, my mouse is not visible in the recording (thanks to latest Wayland update). But just clicking multiple times creates the underline overflow.

Screencast.from.2025-01-25.16-15-29.webm

Is this the desired behaviour? Or are we using that to signify e.g. error severity?

@kasnerz
Copy link
Collaborator

kasnerz commented Jan 29, 2025

Tough question 😄 For one, it's the default behavior we got after implemented it.

Until now I also thought it's a good behavior, as it allows to annotate multiple spans of the same category that are (somehow) overlapping. For example here, I annotated both "Parla Sonic 3.5 is a smartphone" and "smartphone that was released in 2013":

Image

But now I see there are some issues with that:

  • The rendering algorithm does not make it very clear since the level of the second annotation drops to the level of the first annotation after the overlap.
  • People could over-annotate a single span by inadvertently misclicking multiple times.
  • I cannot think of a case where this would be really necessary.

So I guess we can always disallow overlapping spans of a single category.

@kasnerz kasnerz added the bug Something isn't working label Jan 29, 2025
@tuetschek
Copy link
Member

I'm still not sure it's a bad behavior... I annotated this and it made sense to me:

Image

  • Gusty winds aren't noticeable at dawn on Tuesday
  • There's no weather change on Tuesday

@kasnerz
Copy link
Collaborator

kasnerz commented Feb 3, 2025

I made a compromise 🙃

We now forbid multiple equivalent annotations (same span, same type): #201 .

@kasnerz kasnerz closed this as completed Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants