Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.x - Provide base CSS stylesheets #908

Closed
2 tasks
bspeare opened this issue Nov 29, 2023 · 3 comments
Closed
2 tasks

4.x - Provide base CSS stylesheets #908

bspeare opened this issue Nov 29, 2023 · 3 comments
Labels
4.x 4.x version medium story pointing

Comments

@bspeare
Copy link
Contributor

bspeare commented Nov 29, 2023

Story

As a user of uids.brand.uiowa.edu, I can copy and paste markup and CSS from each component to use on my website or application.

3.x Solution

For 3.x we have been providing CSS on https://brand.uiowa.edu/applying-brand/web#heading6951:

To utilize the brand bar on your website or application, you will need to use the following CSS files in the order that they are listed below.

    https://github.com/uiowa/uids/blob/main/dist/css/fonts.css
    https://github.com/uiowa/uids/blob/main/dist/css/reset.css
    https://github.com/uiowa/uids/blob/main/dist/css/components/iowa-bar.css

Proposed 4.x Solution

  • Define a build process to produce the assets defined above from 3.x solution
  • Build it!!!
@bspeare bspeare added the 4.x 4.x version label Nov 29, 2023
@bspeare
Copy link
Contributor Author

bspeare commented Nov 29, 2023

This might be blocked until #900 is complete.

@pyrello
Copy link
Contributor

pyrello commented Dec 13, 2023

Maybe https://storybook.js.org/addons/display-element-css is worth trying first?

I'm assuming that this is something that outputs CSS that can be viewed and copied. I would argue that displaying the CSS rather than providing links that we intend to keep in place over time is going to exacerbate the issue we have where people consume UIDS by copying/pasting rather than directly using the assets. I think we should be focusing on trying to get to a point where people can reliably consume the assets because anything else is a maintenance headache for the implementing app and a support headache for us.

@briand44
Copy link

Future slice for all components can be done in consultation with partners so they can weigh in on what would be most valuable to them.

@briand44 briand44 added medium story pointing and removed needs grooming labels Dec 13, 2023
@pyrello pyrello changed the title 4.x - Provide CSS for components 4.x - Provide base CSS stylesheets Dec 14, 2023
@bspeare bspeare self-assigned this Dec 15, 2023
@bspeare bspeare removed their assignment Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.x 4.x version medium story pointing
Projects
None yet
Development

No branches or pull requests

4 participants